-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix py3.11 dataclasses issue #9440
Conversation
Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com>
Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com>
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
This PR was closed because it has been inactive for 7 days since being marked as stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Will merge once the tests pass.
Could you fix the formatting checks? |
Formatting checks are passing now (after I synced my fork). |
We're seeing some CI instability so the tests are taking longer than ususal. I merged main and re-triggered the failing tests (they don't seem related to your changes). Will keep monitoring this PR until it's all green. |
* Fix py3.11 dataclasses issue Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> * Fix py3.11 dataclasses issue in examples/asr/speech_to_text_eval.py Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> --------- Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> Co-authored-by: Piotr Żelasko <petezor@gmail.com>
* Fix py3.11 dataclasses issue Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> * Fix py3.11 dataclasses issue in examples/asr/speech_to_text_eval.py Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> --------- Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> Co-authored-by: Piotr Żelasko <petezor@gmail.com>
What does this PR do ?
Fixes #9419.
Collection: [ASR]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type:
Additional Information
dataclasses ValueError: mutable default * for field * is not allowed: use default_factory
#7166.