Fix py3.11 dataclasses issue #9440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com>
Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
pzelasko
approved these changes
Aug 3, 2024
|
Could you fix the formatting checks? |
titu1994
reviewed
Aug 3, 2024
Formatting checks are passing now (after I synced my fork). |
|
We're seeing some CI instability so the tests are taking longer than ususal. I merged main and re-triggered the failing tests (they don't seem related to your changes). Will keep monitoring this PR until it's all green. |
titu1994
approved these changes
Aug 14, 2024
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Aug 16, 2024
* Fix py3.11 dataclasses issue Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> * Fix py3.11 dataclasses issue in examples/asr/speech_to_text_eval.py Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> --------- Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> Co-authored-by: Piotr Żelasko <petezor@gmail.com>
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Aug 19, 2024
* Fix py3.11 dataclasses issue Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> * Fix py3.11 dataclasses issue in examples/asr/speech_to_text_eval.py Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> --------- Signed-off-by: Mohamed Aymane Farhi <aymenfarhi.25@gmail.com> Co-authored-by: Piotr Żelasko <petezor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes #9419.
Collection: [ASR]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type:
Additional Information
dataclasses ValueError: mutable default * for field * is not allowed: use default_factory#7166.