Unwrap ckpt_io for model opt (async save) (#9622) #9634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
dimapihtar
added a commit
that referenced
this pull request
Jul 11, 2024
* Change default parallel_save to False (#9633) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Unwrap ckpt_io for model opt (async save) (#9622) (#9634) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add reset_lr documentation Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * add image Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix typo Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * change plot size Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * move image Signed-off-by: dimapihtar <dpihtar@gmail.com> * add reset_lr to intro page Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Co-authored-by: mikolajblaz <mikolajblaz@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
* Change default parallel_save to False (#9633) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Unwrap ckpt_io for model opt (async save) (#9622) (#9634) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add reset_lr documentation Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * add image Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix typo Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * change plot size Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * move image Signed-off-by: dimapihtar <dpihtar@gmail.com> * add reset_lr to intro page Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Co-authored-by: mikolajblaz <mikolajblaz@users.noreply.github.com>
maanug-nv
pushed a commit
that referenced
this pull request
Jul 14, 2024
* Change default parallel_save to False (#9633) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Unwrap ckpt_io for model opt (async save) (#9622) (#9634) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add reset_lr documentation Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * add image Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix typo Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * change plot size Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * move image Signed-off-by: dimapihtar <dpihtar@gmail.com> * add reset_lr to intro page Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Co-authored-by: mikolajblaz <mikolajblaz@users.noreply.github.com>
dimapihtar
added a commit
that referenced
this pull request
Aug 27, 2024
* Change default parallel_save to False (#9633) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Unwrap ckpt_io for model opt (async save) (#9622) (#9634) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add reset_lr documentation Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * add image Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix typo Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * change plot size Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * move image Signed-off-by: dimapihtar <dpihtar@gmail.com> * add reset_lr to intro page Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Co-authored-by: mikolajblaz <mikolajblaz@users.noreply.github.com>
dimapihtar
added a commit
that referenced
this pull request
Aug 28, 2024
* Change default parallel_save to False (#9633) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Unwrap ckpt_io for model opt (async save) (#9622) (#9634) Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add reset_lr documentation Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * add image Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix typo Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix plot Signed-off-by: dimapihtar <dpihtar@gmail.com> * change plot size Signed-off-by: dimapihtar <dpihtar@gmail.com> * fix style Signed-off-by: dimapihtar <dpihtar@gmail.com> * move image Signed-off-by: dimapihtar <dpihtar@gmail.com> * add reset_lr to intro page Signed-off-by: dimapihtar <dpihtar@gmail.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Co-authored-by: mikolajblaz <mikolajblaz@users.noreply.github.com>
ericharper
pushed a commit
that referenced
this pull request
Aug 29, 2024
* Change default parallel_save to False (#9633) * Unwrap ckpt_io for model opt (async save) (#9622) (#9634) * add reset_lr documentation * fix style * fix style * fix style * add image * fix typo * fix plot * fix plot * change plot size * fix style * move image * add reset_lr to intro page --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com> Co-authored-by: mikolajblaz <mikolajblaz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Cherry-pick of #9622
Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information