Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NeMo-UX] Make 'load_directly_on_device' configurable #9657

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

ashors1
Copy link
Collaborator

@ashors1 ashors1 commented Jul 9, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: ashors1 <ashors@nvidia.com>
marcromeyn
marcromeyn previously approved these changes Jul 9, 2024
@ashors1 ashors1 added Run CICD and removed Run CICD labels Jul 9, 2024
@ashors1 ashors1 force-pushed the ashors/nemo-ux-load-on-device branch from cd8f28e to 67e05c1 Compare July 10, 2024 16:40
@github-actions github-actions bot removed core Changes to NeMo Core NLP CI Multi Modal labels Jul 10, 2024
@ashors1 ashors1 added Run CICD and removed Run CICD labels Jul 10, 2024
@ashors1 ashors1 merged commit 0b61055 into r2.0.0rc1 Jul 10, 2024
114 checks passed
@ashors1 ashors1 deleted the ashors/nemo-ux-load-on-device branch July 10, 2024 18:47
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
Signed-off-by: ashors1 <ashors@nvidia.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
ashors1 added a commit that referenced this pull request Jul 10, 2024
Signed-off-by: ashors1 <ashors@nvidia.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
maanug-nv pushed a commit that referenced this pull request Jul 14, 2024
Signed-off-by: ashors1 <ashors@nvidia.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
ashors1 added a commit that referenced this pull request Jul 16, 2024
Signed-off-by: ashors1 <ashors@nvidia.com>
Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
nikitaved pushed a commit to nikitaved/NeMo that referenced this pull request Jul 16, 2024
Signed-off-by: ashors1 <ashors@nvidia.com>
Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
ertkonuk pushed a commit that referenced this pull request Jul 19, 2024
Signed-off-by: ashors1 <ashors@nvidia.com>
Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Tugrul Konuk <ertkonuk@gmail.com>
malay-nagda pushed a commit to malay-nagda/NeMo that referenced this pull request Jul 26, 2024
Signed-off-by: ashors1 <ashors@nvidia.com>
Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Malay Nagda <malayn@malayn-mlt.client.nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants