Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NeMo-UX] Make 'load_directly_on_device' configurable #9657

Merged
merged 4 commits into from
Jul 10, 2024
Merged

[NeMo-UX] Make 'load_directly_on_device' configurable #9657

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57373a5
make 'load_directly_on_device' configurable
ashors1 Jul 8, 2024
1c886a8
Merge branch 'r2.0.0rc1' into ashors/nemo-ux-load-on-device
pablo-garay Jul 9, 2024
f0f1ca9
Merge branch 'r2.0.0rc1' into ashors/nemo-ux-load-on-device
pablo-garay Jul 9, 2024
67e05c1
Merge branch 'r2.0.0rc1' of github.com:NVIDIA/NeMo into ashors/nemo-u…
ashors1 Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nemo/lightning/pytorch/strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ def __init__(
ckpt_parallel_save_within_dp=False,
ckpt_parallel_load=False,
ckpt_parallel_save_optim=True,
ckpt_load_directly_on_device=True,
setup_optimizers: bool = True,
init_model_parallel: bool = True,
**kwargs,
Expand Down Expand Up @@ -147,6 +148,7 @@ def __init__(
self.parallel_save_within_dp = ckpt_parallel_save_within_dp
self.parallel_load = ckpt_parallel_load
self.parallel_save_optim = ckpt_parallel_save_optim
self.load_directly_on_device = ckpt_load_directly_on_device

self._ddp = ddp
if ddp == "megatron":
Expand Down Expand Up @@ -582,6 +584,7 @@ def checkpoint_io(self) -> CheckpointIO:
parallel_save=self.parallel_save,
parallel_save_within_dp=self.parallel_save_within_dp,
parallel_load=self.parallel_load,
load_directly_on_device=self.load_directly_on_device,
)
if async_save:
self._checkpoint_io = AsyncFinalizableCheckpointIO(self._checkpoint_io)
Expand Down
Loading