Run a sample query for a quantized model conditionally #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
janekl
force-pushed
the
jlasek/sample_prompt
branch
from
f599645
to
30d54e5
Compare
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
janekl
force-pushed
the
jlasek/sample_prompt
branch
from
30d54e5
to
e671b71
Compare
pablo-garay
requested changes
Jul 29, 2024
|
CICD passed: https://github.com/NVIDIA/NeMo/actions/runs/10143611183 can merge once the review comments have been addressed (no need to re-run CI after that) |
This reverts commit e671b71. Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
8 tasks
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jul 30, 2024
* Run a sample query for a quantized model conditionally Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * L2_PTQ_Llama2_INT8_SQ mandatory again Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "L2_PTQ_Llama2_INT8_SQ mandatory again" This reverts commit e671b71. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Reindent Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
* Run a sample query for a quantized model conditionally Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * L2_PTQ_Llama2_INT8_SQ mandatory again Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Revert "L2_PTQ_Llama2_INT8_SQ mandatory again" This reverts commit e671b71. Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Reindent Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: Vivian Chen <xuanzic@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adding a flag to run
_sample_outputinQuantizeron demand (defaults toTrue) as this step often hangs for a few minutes at (see here):and this is to disable sample query in Github CI.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information