Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NeMo-UX] Adding recipes #9720

Merged
merged 27 commits into from
Jul 23, 2024
Merged

[NeMo-UX] Adding recipes #9720

merged 27 commits into from
Jul 23, 2024

Conversation

marcromeyn
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@marcromeyn marcromeyn changed the title Nemo ux/llm factories [NeMo-UX] Adding recipies Jul 12, 2024
@marcromeyn marcromeyn changed the title [NeMo-UX] Adding recipies [NeMo-UX] Adding recipes Jul 12, 2024
@marcromeyn marcromeyn force-pushed the nemo-ux/llm-factories branch 2 times, most recently from 7e13c5c to 88cc473 Compare July 12, 2024 15:50
marcromeyn and others added 16 commits July 17, 2024 17:20
@marcromeyn @ashors1
Adding recipy proposal
9aeb7ce 
Signed-off-by: ashors1 <ashors@nvidia.com>
@marcromeyn @ashors1
Adding more recipies
648a12b 
Signed-off-by: ashors1 <ashors@nvidia.com>
@artbataev @ashors1
Apply isort and black reformatting
6c8d933 
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
@marcromeyn @ashors1
Remove api.py inside llm.gpt.model
bd6ccaa 
Signed-off-by: ashors1 <ashors@nvidia.com>
@marcromeyn @ashors1
Adding resume to FineTuneRecipy
90b02ac 
Signed-off-by: ashors1 <ashors@nvidia.com>
@marcromeyn @ashors1
Fix spelling error
3b18c83 
Signed-off-by: ashors1 <ashors@nvidia.com>
@marcromeyn @ashors1
Fix spelling error
27ab061 
Signed-off-by: ashors1 <ashors@nvidia.com>
@marcromeyn @ashors1
Fix spelling error
175d00e 
Signed-off-by: ashors1 <ashors@nvidia.com>
@marcromeyn @ashors1
Apply isort and black reformatting
888f87f 
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
@marcromeyn @ashors1
Adding resume to PreTrainRecipe
c7a200b 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
update recipe proposal to use sdk.Partial
8f25855 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
Apply isort and black reformatting
ff9e011 
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
update __init__
e6716cf 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
update __init__
04ff16c 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
fix return type
0147133 
Signed-off-by: ashors1 <ashors@nvidia.com>
@hemildesai @ashors1
Fix bug in factory
71e36fb 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 marked this pull request as ready for review July 18, 2024 00:21
@ashors1
rename recipe folder to 'models'
0be29ac 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 added Run CICD and removed Run CICD labels Jul 18, 2024
hemildesai and others added 3 commits July 17, 2024 19:05
@hemildesai
Fixes
d1571cf 
Signed-off-by: Hemil Desai <hemild@nvidia.com>
@hemildesai
Apply isort and black reformatting
ad97b1b 
Signed-off-by: hemildesai <hemildesai@users.noreply.github.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
@hemildesai
Bug fixes
3d63241 
Signed-off-by: Hemil Desai <hemild@nvidia.com>
@ashors1 ashors1 added Run CICD and removed Run CICD labels Jul 18, 2024
@ashors1 ashors1 requested review from cuichenx and akoumpa July 19, 2024 03:30
akoumpa
akoumpa requested changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@akoumpa akoumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the directory models to recipes?

Otherwise it's confusing why there's a mistral.py under both collections/llm/gpt/model and collections/llm/models.
I don't have any strong preference as long as one of the two directories changes name.

ashors1 and others added 6 commits July 19, 2024 12:52
@ashors1
rename models --> configs
79087a1 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
Apply isort and black reformatting
d5898de 
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
@ashors1
rename configs --> recipes
e87aa69 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
Apply isort and black reformatting
fddc03f 
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
@ashors1
address comments
c37143f 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
Merge branch 'nemo-ux/llm-factories' of github.com:NVIDIA/NeMo into n…
dacafc2 
…emo-ux/llm-factories
@ashors1
Copy link
Collaborator

ashors1 commented Jul 20, 2024

Can we rename the directory models to recipes?

Otherwise it's confusing why there's a mistral.py under both collections/llm/gpt/model and collections/llm/models. I don't have any strong preference as long as one of the two directories changes name.

Done

@ashors1 ashors1 requested a review from akoumpa July 20, 2024 00:16
@ashors1 ashors1 added Run CICD and removed Run CICD labels Jul 20, 2024
@akoumpa akoumpa merged commit b7a494e into r2.0.0rc1 Jul 23, 2024
118 checks passed
@akoumpa akoumpa deleted the nemo-ux/llm-factories branch July 23, 2024 16:14
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
@marcromeyn @artbataev
@ashors1 @hemildesai @web-flow
[NeMo-UX] Adding recipes (#9720)
63cf9eb 
* Adding recipy proposal

Signed-off-by: ashors1 <ashors@nvidia.com>

* Adding more recipies

Signed-off-by: ashors1 <ashors@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: ashors1 <ashors@nvidia.com>

* Remove api.py inside llm.gpt.model

Signed-off-by: ashors1 <ashors@nvidia.com>

* Adding resume to FineTuneRecipy

Signed-off-by: ashors1 <ashors@nvidia.com>

* Fix spelling error

Signed-off-by: ashors1 <ashors@nvidia.com>

* Fix spelling error

Signed-off-by: ashors1 <ashors@nvidia.com>

* Fix spelling error

Signed-off-by: ashors1 <ashors@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Signed-off-by: ashors1 <ashors@nvidia.com>

* Adding resume to PreTrainRecipe

Signed-off-by: ashors1 <ashors@nvidia.com>

* update recipe proposal to use sdk.Partial

Signed-off-by: ashors1 <ashors@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: ashors1 <ashors@nvidia.com>

* update __init__

Signed-off-by: ashors1 <ashors@nvidia.com>

* update __init__

Signed-off-by: ashors1 <ashors@nvidia.com>

* fix return type

Signed-off-by: ashors1 <ashors@nvidia.com>

* Fix bug in factory

Signed-off-by: ashors1 <ashors@nvidia.com>

* rename recipe folder to 'models'

Signed-off-by: ashors1 <ashors@nvidia.com>

* Fixes

Signed-off-by: Hemil Desai <hemild@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: hemildesai <hemildesai@users.noreply.github.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>

* Bug fixes

Signed-off-by: Hemil Desai <hemild@nvidia.com>

* rename models --> configs

Signed-off-by: ashors1 <ashors@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: ashors1 <ashors1@users.noreply.github.com>

* rename configs --> recipes

Signed-off-by: ashors1 <ashors@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: ashors1 <ashors1@users.noreply.github.com>

* address comments

Signed-off-by: ashors1 <ashors@nvidia.com>

---------

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: hemildesai <hemildesai@users.noreply.github.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Co-authored-by: ashors1 <ashors1@users.noreply.github.com>
Co-authored-by: Hemil Desai <hemild@nvidia.com>
Co-authored-by: hemildesai <hemildesai@users.noreply.github.com>
ashors1 added a commit that referenced this pull request Jul 30, 2024
@github-actions @marcromeyn
@artbataev @ashors1 @hemildesai
[NeMo-UX] Adding recipes (#9720) (#9851)
bd17e77 
* Adding recipy proposal



* Adding more recipies



* Apply isort and black reformatting




* Remove api.py inside llm.gpt.model



* Adding resume to FineTuneRecipy



* Fix spelling error



* Fix spelling error



* Fix spelling error



* Apply isort and black reformatting




* Adding resume to PreTrainRecipe



* update recipe proposal to use sdk.Partial



* Apply isort and black reformatting




* update __init__



* update __init__



* fix return type



* Fix bug in factory



* rename recipe folder to 'models'



* Fixes



* Apply isort and black reformatting




* Bug fixes



* rename models --> configs



* Apply isort and black reformatting



* rename configs --> recipes



* Apply isort and black reformatting



* address comments



---------

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: hemildesai <hemildesai@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Co-authored-by: ashors1 <ashors1@users.noreply.github.com>
Co-authored-by: Hemil Desai <hemild@nvidia.com>
Co-authored-by: hemildesai <hemildesai@users.noreply.github.com>
Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
@github-actions @marcromeyn
@artbataev @ashors1 @hemildesai @BoxiangW
[NeMo-UX] Adding recipes (NVIDIA#9720) (NVIDIA#9851)
dbf151a 
* Adding recipy proposal

* Adding more recipies

* Apply isort and black reformatting

* Remove api.py inside llm.gpt.model

* Adding resume to FineTuneRecipy

* Fix spelling error

* Fix spelling error

* Fix spelling error

* Apply isort and black reformatting

* Adding resume to PreTrainRecipe

* update recipe proposal to use sdk.Partial

* Apply isort and black reformatting

* update __init__

* update __init__

* fix return type

* Fix bug in factory

* rename recipe folder to 'models'

* Fixes

* Apply isort and black reformatting

* Bug fixes

* rename models --> configs

* Apply isort and black reformatting

* rename configs --> recipes

* Apply isort and black reformatting

* address comments

---------

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: hemildesai <hemildesai@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Co-authored-by: ashors1 <ashors1@users.noreply.github.com>
Co-authored-by: Hemil Desai <hemild@nvidia.com>
Co-authored-by: hemildesai <hemildesai@users.noreply.github.com>
Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
@github-actions @marcromeyn
@artbataev @ashors1 @hemildesai
[NeMo-UX] Adding recipes (NVIDIA#9720) (NVIDIA#9851)
d118c0f 
* Adding recipy proposal

* Adding more recipies

* Apply isort and black reformatting

* Remove api.py inside llm.gpt.model

* Adding resume to FineTuneRecipy

* Fix spelling error

* Fix spelling error

* Fix spelling error

* Apply isort and black reformatting

* Adding resume to PreTrainRecipe

* update recipe proposal to use sdk.Partial

* Apply isort and black reformatting

* update __init__

* update __init__

* fix return type

* Fix bug in factory

* rename recipe folder to 'models'

* Fixes

* Apply isort and black reformatting

* Bug fixes

* rename models --> configs

* Apply isort and black reformatting

* rename configs --> recipes

* Apply isort and black reformatting

* address comments

---------

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: artbataev <artbataev@users.noreply.github.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: hemildesai <hemildesai@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: artbataev <artbataev@users.noreply.github.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Co-authored-by: ashors1 <ashors1@users.noreply.github.com>
Co-authored-by: Hemil Desai <hemild@nvidia.com>
Co-authored-by: hemildesai <hemildesai@users.noreply.github.com>
Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com>
Signed-off-by: Vivian Chen <xuanzic@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashors1 ashors1 ashors1 left review comments

@akoumpa akoumpa akoumpa approved these changes

@ericharper ericharper Awaiting requested review from ericharper

@cuichenx cuichenx Awaiting requested review from cuichenx

Assignees
No one assigned
Labels
Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marcromeyn @ashors1 @akoumpa @artbataev @hemildesai