Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Allow bias support for sm80/86/89 for cuDNN 9+ #863

Merged
merged 2 commits into from
May 25, 2024

Conversation

cyanguwa
Copy link
Collaborator

Description

This PR opens up the restriction on post_scale_bias support for sm80/86/89 when cuDNN 9.0+ is installed.

Fixes QA tests for test_cp_with_fused_attention on sm80/86/89.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes

  • Allows the use of F16_arbitrary_seqlen backend when post_scale_bias is run on sm80/86/89 with cuDNN 9.0+.

Checklist:

  • [x ] I have read and followed the contributing guidelines
  • [x ] The functionality is complete
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes

Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
@cyanguwa cyanguwa requested a review from ptrendx May 23, 2024 19:28
@timmoon10
Copy link
Collaborator

/te-ci

@timmoon10 timmoon10 merged commit 223050a into NVIDIA:main May 25, 2024
26 checks passed
timmoon10 pushed a commit that referenced this pull request May 25, 2024
allow bias support for sm80/86/89 for cuDNN 9+

Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants