Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't patch tensor ops that aren't present #899

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Don't patch tensor ops that aren't present #899

merged 2 commits into from
Jun 30, 2020

Conversation

mcarilli
Copy link
Contributor

@mcarilli mcarilli commented Jun 30, 2020

Gives pytorch the liberty to remove some Tensor methods if desired (e.g. __div__, pytorch/pytorch#39151)

Necessary as a stopgap to support existing scripts that use apex amp with recent pytorch. Fix is not an endorsement of apex amp over torch.cuda.amp. torch.cuda.amp is still 100% the best way forward.

Fixes errors with pytorch/pytorch#39151 and Amp tests pass locally.

@mcarilli mcarilli merged commit 43a6f9f into master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants