Add icc compiler to CI matrix

[jrhemstad]

closes #140

Description

Adds a build job for icx with CUDA newest.

[jrhemstad]

Need to investigate: The verify-devcontainers job should be failing because there isn't a corresponding oneapi devcontainer yet.

[jrhemstad]

@gevtushenko The CI failure on the new oneapi jobs seems to be the same as the issue you fixed in: #1152

I double checked and my branch already incorporates your fixes, so something else must be going on.

Relevant log line: https://github.com/NVIDIA/cccl/actions/runs/7027282524/job/19121499268?pr=1159#step:7:1217

[miscco]

They have to be kidding us:

error #1407-D: the "__visibility__" attribute can only appear on functions and variables with external linkage
    __attribute__((global)) __attribute__ ((__visibility__("hidden"))) void __attribute__((launch_bounds(Agent::ptx_plan::BLOCK_THREADS)))

However, with the new llvm based compiler the warning is:

error #1890: the "__visibility__" attribute can only appear on functions and variables with external linkage
 __attribute((__visibility__("hidden"))) static void __wrapper__device_stub_DeviceScanInitKernel(ScanTileStateT &tile_state, int &num_tiles) { ::cudaLaunchKernel(0, 0, 0, 0, 0, 0);}

Note that once the error number is 1407 and the other time it is 1890 🤦‍♂️

[miscco]

Also we should be testing against the new one and not the already discontinued classic one

[jrhemstad]

Also we should be testing against the new one and not the already discontinued classic one

No, icx isn't supported by CUDA. icc is the supported compiler.

[jrhemstad]

Needed to set CUDAHOSTCXX in the devcontainer: rapidsai/devcontainers#181

[miscco]

Something here is fishy, in the error logs I find:

lit: /home/coder/cccl/libcudacxx/test/utils/libcudacxx/test/config.py:364: note: detected host_cxx.version as: (20.21, 2.1, 1)

[jrhemstad]

I think this is because 2021.10 is the last release of the "classic" compilers that is bundled with the OneAPI package.

[jrhemstad]

@miscco it looks like all the icc tests are still failing because of the warning despite the changes you pushed. Any idea what is going on?

[miscco]

The only thing that changed was icc ->icpc, so I am not sure Maybe we just disable both?

[jrhemstad]

The only thing that changed was icc ->icpc, so I am not sure Maybe we just disable both?

It was never actually passing before. The previous passing jobs were a lie because of the bug where jobs would report success even though the build failed.

[miscco]

@gevtushenko I am seeing issues with nvbench build here:

  icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
  ld: lib/libnvbench.so: undefined reference to `std::experimental::filesystem::v1::create_directory(std::experimental::filesystem::v1::__cxx11::path const&)'
  ld: lib/libnvbench.so: undefined reference to `std::experimental::filesystem::v1::status(std::experimental::filesystem::v1::__cxx11::path const&)'
  ld: lib/libnvbench.so: undefined reference to `std::experimental::filesystem::v1::__cxx11::path::_M_split_cmpts()'

[gevtushenko]

@gevtushenko I am seeing issues with nvbench build here:

  icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
  ld: lib/libnvbench.so: undefined reference to `std::experimental::filesystem::v1::create_directory(std::experimental::filesystem::v1::__cxx11::path const&)'
  ld: lib/libnvbench.so: undefined reference to `std::experimental::filesystem::v1::status(std::experimental::filesystem::v1::__cxx11::path const&)'
  ld: lib/libnvbench.so: undefined reference to `std::experimental::filesystem::v1::__cxx11::path::_M_split_cmpts()'

Feel free to disable benchmarks build for icc

[jrhemstad]

@miscco it looks like icc doesn't like variant https://github.com/NVIDIA/cccl/actions/runs/7187654730/job/19575804068?pr=1159#step:8:1957

[github-actions]

Backport failed for branch/2.3.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin branch/2.3.x
git worktree add -d .worktree/backport-1159-to-branch/2.3.x origin/branch/2.3.x
cd .worktree/backport-1159-to-branch/2.3.x
git checkout -b backport-1159-to-branch/2.3.x
ancref=$(git merge-base bf098efd7fd8d3d686fa7bf9f47811600c421088 8d7355b0c2efd86f623ebc15a76c218df7381b5d)
git cherry-pick -x $ancref..8d7355b0c2efd86f623ebc15a76c218df7381b5d