Attempt to WAR CUB / RDC / MSVC issue #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
requested review from
wmaxey and
miscco
and removed request for
a team
miscco
approved these changes
Nov 7, 2023
wmaxey
reviewed
Nov 7, 2023
| @@ -23,7 +23,14 @@ list(FILTER CUB_CUDA_ARCHITECTURES_RDC EXCLUDE REGEX "53|62|72|90") | |||
| message(STATUS "CUB_CUDA_ARCHITECTURES: ${CUB_CUDA_ARCHITECTURES}") | |||
| message(STATUS "CUB_CUDA_ARCHITECTURES_RDC: ${CUB_CUDA_ARCHITECTURES_RDC}") | |||
|
|
|||
| option(CUB_ENABLE_RDC_TESTS "Enable tests that require separable compilation." ON) | |||
| if ("MSVC" STREQUAL "${CMAKE_CXX_COMPILER_ID}") | |||
There was a problem hiding this comment.
Suggested change
| if ("MSVC" STREQUAL "${CMAKE_CXX_COMPILER_ID}") | |
| if (MSVC) |
There was a problem hiding this comment.
I didn't know there was a short version for this check, thank you! Since it's functionally equivalent and there are many usages of the long version, I'll keep the code as is, but will keep this in mind.
miscco
pushed a commit
to miscco/cccl
that referenced
this pull request
Dec 13, 2023
jrhemstad
pushed a commit
to miscco/cccl
that referenced
this pull request
Dec 13, 2023
jrhemstad
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to WAR CUB linkage issue in MSVC CI
Checklist