PTX: Add helper functions for dsmem #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- __as_ptr_dsmem
- __from_ptr_{smem, dsmem, remote_dsmem, gmem}
ahendriksen
force-pushed
the
integrate-ptx
branch
from
c363edd
to
f60e347
Compare
miscco
reviewed
Feb 5, 2024
libcudacxx/include/cuda/std/detail/libcxx/include/__cuda/ptx/ptx_helper_functions.h
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__cuda/ptx/ptx_helper_functions.h
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__cuda/ptx/ptx_helper_functions.h
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/cuda/ptx/ptx.mbarrier.arrive.compile.pass.cpp
Outdated
Show resolved
Hide resolved
...libcxx/include/__cuda/ptx/parallel_synchronization_and_communication_instructions_mbarrier.h
Show resolved
Hide resolved
...libcxx/include/__cuda/ptx/parallel_synchronization_and_communication_instructions_mbarrier.h
Outdated
Show resolved
Hide resolved
ahendriksen
commented
Feb 5, 2024
...libcxx/include/__cuda/ptx/parallel_synchronization_and_communication_instructions_mbarrier.h
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__cuda/ptx/ptx_helper_functions.h
Outdated
Show resolved
Hide resolved
libcudacxx/include/cuda/std/detail/libcxx/include/__cuda/ptx/ptx_helper_functions.h
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/cuda/ptx/ptx.mbarrier.arrive.compile.pass.cpp
Outdated
Show resolved
Hide resolved
...libcxx/include/__cuda/ptx/parallel_synchronization_and_communication_instructions_mbarrier.h
Outdated
Show resolved
Hide resolved
miscco
approved these changes
Feb 5, 2024
libcudacxx/test/libcudacxx/cuda/ptx/ptx.mbarrier.arrive.compile.pass.cpp
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/cuda/ptx/ptx.mbarrier.wait.compile.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/cuda/ptx/ptx.mbarrier.arrive.compile.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/cuda/ptx/ptx.red.async.compile.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/cuda/ptx/ptx.st.async.compile.pass.cpp
Outdated
Show resolved
Hide resolved
The newer mbarrier.arrive instructions accept .shared::cta instead of .shared. Updated for clarity.
|
The spurious newlines have been removed. One minor addition is the use of |
miscco
approved these changes
Feb 5, 2024
|
Is this one good to merge? I have added a follow-up PR: #1341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prepares the
cuda::ptxcode for the addition of more instructions. It adds:cuda::ptx::n32integral constant type that can be used with"n"annotated inline PTX instructions.__as_ptr_dsmemfunction for pointers that may point to local or remote distributed shared memory__from_ptr_*functions that map back from a state-space specific pointer to a generic pointer.In addition, the error functions that are used to generate link-time errors in case of an architecture mismatch are now renamed and all return void. While writing new instruction wrappers, it turned out to be unsustainable to have the error functions generate a return value, especially with templates.
Finally, there are some whitespace and comments changes that make it easier to contribute code in the future.
Checklist