-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small update to docs for CTK #1378
Conversation
/ok to test |
@@ -12,6 +12,8 @@ CCCL uses [Development Containers](https://containers.dev/) to provide consisten | |||
### Prerequisites | |||
- [Visual Studio Code](https://code.visualstudio.com/) | |||
- [Remote - Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) | |||
- [NVIDIA Container Toolkit](https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm realizing this list doesn't include Docker
. I can't recall why I would have neglected to include that. Do you think we should include that for completeness too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow I didn't notice that either 😅. I guess it's because I'm familiar with devcontainers and know that it's a requirement. For someone who's unfamiliar with docker and/or devcontainers, that won't be as obvious. I'll add it in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrhemstad @ZelboK The Remote - Containers extension (we should probably rename it to Dev Containers Extension btw within our guide) does install docker underneath. No need to add it explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't know it installs it for you. I can remove it @jrhemstad unless you think otherwise
Head branch was pushed to by a user without write access
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @ZelboK !
* small update to docs for CTK * undo change * add docker to devcontainer as prereq * Update .devcontainer/README.md Co-authored-by: Jake Hemstad <jhemstad@nvidia.com> --------- Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
* small update to docs for CTK * undo change * add docker to devcontainer as prereq * Update .devcontainer/README.md Co-authored-by: Jake Hemstad <jhemstad@nvidia.com> --------- Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
* small update to docs for CTK * undo change * add docker to devcontainer as prereq * Update .devcontainer/README.md Co-authored-by: Jake Hemstad <jhemstad@nvidia.com> --------- Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
Description
#1332
Just a small update to the prerequisites for the devcontainers. I've seen a few people run into problems getting their CUDA related tests to run because they haven't installed the toolkit.
https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html
Checklist