Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small update to docs for CTK #1378

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

ZelboK
Copy link
Contributor

@ZelboK ZelboK commented Feb 14, 2024

Description

#1332

Just a small update to the prerequisites for the devcontainers. I've seen a few people run into problems getting their CUDA related tests to run because they haven't installed the toolkit.

https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ZelboK ZelboK requested review from a team as code owners February 14, 2024 15:45
Copy link

copy-pr-bot bot commented Feb 14, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@miscco
Copy link
Collaborator

miscco commented Feb 14, 2024

/ok to test

@miscco miscco enabled auto-merge (squash) February 14, 2024 17:23
@@ -12,6 +12,8 @@ CCCL uses [Development Containers](https://containers.dev/) to provide consisten
### Prerequisites
- [Visual Studio Code](https://code.visualstudio.com/)
- [Remote - Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers)
- [NVIDIA Container Toolkit](https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm realizing this list doesn't include Docker. I can't recall why I would have neglected to include that. Do you think we should include that for completeness too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I didn't notice that either 😅. I guess it's because I'm familiar with devcontainers and know that it's a requirement. For someone who's unfamiliar with docker and/or devcontainers, that won't be as obvious. I'll add it in!

Copy link
Member

@gonidelis gonidelis Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrhemstad @ZelboK The Remote - Containers extension (we should probably rename it to Dev Containers Extension btw within our guide) does install docker underneath. No need to add it explicitly.

Copy link
Contributor Author

@ZelboK ZelboK Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know it installs it for you. I can remove it @jrhemstad unless you think otherwise

auto-merge was automatically disabled February 14, 2024 22:16

Head branch was pushed to by a user without write access

.devcontainer/README.md Outdated Show resolved Hide resolved
Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
Copy link
Collaborator

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @ZelboK !

@jrhemstad jrhemstad merged commit 56b358d into NVIDIA:main Feb 15, 2024
2 checks passed
elstehle pushed a commit to elstehle/cccl that referenced this pull request Feb 16, 2024
* small update to docs for CTK

* undo change

* add docker to devcontainer as prereq

* Update .devcontainer/README.md

Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>

---------

Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
elstehle pushed a commit to elstehle/cccl that referenced this pull request Feb 17, 2024
* small update to docs for CTK

* undo change

* add docker to devcontainer as prereq

* Update .devcontainer/README.md

Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>

---------

Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
elstehle pushed a commit to elstehle/cccl that referenced this pull request Feb 19, 2024
* small update to docs for CTK

* undo change

* add docker to devcontainer as prereq

* Update .devcontainer/README.md

Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>

---------

Co-authored-by: Jake Hemstad <jhemstad@nvidia.com>
@jrhemstad jrhemstad linked an issue Feb 21, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DOC]: Docs for dev containers should include nvidia container toolkit
4 participants