Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dev Containers guide for WSL #1394

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Add Dev Containers guide for WSL #1394

merged 6 commits into from
Mar 7, 2024

Conversation

gonidelis
Copy link
Member

@gonidelis gonidelis commented Feb 16, 2024

Description

Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, some minor docs structure comment

.devcontainer/README.md Outdated Show resolved Hide resolved
.devcontainer/README.md Outdated Show resolved Hide resolved
.devcontainer/README.md Outdated Show resolved Hide resolved
@jrhemstad jrhemstad linked an issue Feb 21, 2024 that may be closed by this pull request
1 task
exec: "xdg-open,x-www-browser,www-browser,wslview": executable file not found in $PATH
Please try entering the URL in your browser manually

In that case type in the address manually in your web browser https://github.com/login/device and fill in the one-time code.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a random 1st time user/installer, these instructions worked well for me.
Thanks

@gonidelis gonidelis changed the title Dev Containers on WSL instruction and remove gpu dependency from devcontainers configs Add Dev Containers guide for WSL Feb 28, 2024
@gonidelis gonidelis force-pushed the wsl_guide branch 2 times, most recently from beb5c30 to 88bc471 Compare March 4, 2024 22:57
@gonidelis gonidelis requested a review from miscco March 4, 2024 22:57
@gonidelis
Copy link
Member Author

@miscco @jrhemstad @gevtushenko merge?

.devcontainer/README.md Outdated Show resolved Hide resolved
@gonidelis gonidelis requested a review from miscco March 5, 2024 19:41
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instruction is great! Just a few nits below.

.devcontainer/README.md Outdated Show resolved Hide resolved
.devcontainer/README.md Outdated Show resolved Hide resolved
@gonidelis gonidelis force-pushed the wsl_guide branch 2 times, most recently from 80e0e44 to 19f43f8 Compare March 5, 2024 22:12
gonidelis and others added 6 commits March 6, 2024 10:40
Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
Co-authored-by: Georgii Evtushenko <evtushenko.georgy@gmail.com>
Co-authored-by: Georgii Evtushenko <evtushenko.georgy@gmail.com>
@miscco miscco merged commit 890c1dd into NVIDIA:main Mar 7, 2024
584 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
4 participants