Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Change devcontainer.json to not require a GPU #1384

Closed
1 task done
jrhemstad opened this issue Feb 14, 2024 · 0 comments · Fixed by #1394
Closed
1 task done

[FEA]: Change devcontainer.json to not require a GPU #1384

jrhemstad opened this issue Feb 14, 2024 · 0 comments · Fixed by #1394
Assignees
Labels
feature request New feature or request.

Comments

@jrhemstad
Copy link
Collaborator

jrhemstad commented Feb 14, 2024

Is this a duplicate?

Area

Infrastructure

Is your feature request related to a problem? Please describe.

As a CCCL developer, I'd like to be able to use the DevContainers without necessarily needing a GPU because I could be interested in just compiling the tests and not actually running them.

However, CCCL's devcontainer.json currently lists a GPU as a host requirement:

"hostRequirements": {
"gpu": true
},

Describe the solution you'd like

We should instead list a GPU as optional:

  "hostRequirements": {
    "gpu": "optional"
  },

Describe alternatives you've considered

No response

Additional context

No response

@jrhemstad jrhemstad added the feature request New feature or request. label Feb 14, 2024
@jrhemstad jrhemstad linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants