Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sm_90a in <nv/target> API #1411

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

ahendriksen
Copy link
Contributor

The new API be used as follows:

__global__ void kernel(int *out) {
    NV_DISPATCH_TARGET(
        NV_HAS_FEATURE_SM_90a, (
        *out = 901;
    ), NV_PROVIDES_SM_90, (
        *out = 900;
    ), NV_IS_DEVICE, (
        *out = 0;
    ));
}

Description

closes #1270

Checklist

Can be used as follows:

__global__ void kernel(int *out) {
    NV_DISPATCH_TARGET(
        NV_HAS_FEATURE_SM_90a, (
        *out = 901;
    ), NV_PROVIDES_SM_90, (
        *out = 900;
    ), NV_IS_DEVICE, (
        *out = 0;
    ));
}
@wmaxey
Copy link
Member

wmaxey commented Feb 20, 2024

The solution looks fine to me. As long as this is strictly an NVCC concern then I'm happy with this. Thanks for taking the initiative to plug support in.

@ahendriksen
Copy link
Contributor Author

IIUC, nvc++ does not support emitting SM90a code (I think it doesn't have the command-line parameters to specify sm90a?). So this PR supports all compilers to the maximum extent possible.

@ahendriksen
Copy link
Contributor Author

Can we merge this PR?

@miscco miscco merged commit aa566de into NVIDIA:main Feb 23, 2024
539 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support for sm_90a in <nv/target> API
4 participants