Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: NV_HAS_FEATURE_SM_90a does not work with nvrtc #1446

Closed
1 task done
ahendriksen opened this issue Feb 27, 2024 · 2 comments
Closed
1 task done

[BUG]: NV_HAS_FEATURE_SM_90a does not work with nvrtc #1446

ahendriksen opened this issue Feb 27, 2024 · 2 comments
Labels
bug Something isn't working right.

Comments

@ahendriksen
Copy link
Contributor

Is this a duplicate?

Type of Bug

Compile-time Error

Component

libcu++

Describe the bug

The NV_HAS_FEATURE_SM_90a macro added in #1411 does not suppport NVRTC.

How to Reproduce

CI is failing:

https://github.com/NVIDIA/cccl/actions/runs/8065512120/job/22031531092?pr=1441

Expected behavior

Should work.

Reproduction link

https://github.com/NVIDIA/cccl/actions/runs/8065512120/job/22031531092?pr=1441

Operating System

No response

nvidia-smi output

No response

NVCC version

No response

@ahendriksen ahendriksen added the bug Something isn't working right. label Feb 27, 2024
@miscco
Copy link
Collaborator

miscco commented Feb 28, 2024

I addressed this in you PR, the issue is that nvrtc uses its own nv/target header, so we need to manually tell it what we expect

@ahendriksen
Copy link
Contributor Author

Fixed by #1441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right.
Projects
Archived in project
Development

No branches or pull requests

2 participants