Try harder to unwrap nested thrust::tuple_of_iterator_references
#1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
alliepiper,
griwes and
gevtushenko
and removed request for
griwes
miscco
added
thrust
miscco
removed
the
backport branch/2.4.x
We were defining our own set of iterator categories That meant that an interator that is a `std::random_access_iterator` would not be a `cuda::std::random_access_iterator` To ensure that we are playing nicely with iterators that use `std::` iterator categories just pull in the standard ones. Fixes [BUG]: cuda::std::iterator_traits does not expose proper member types in old C++ dialects NVIDIA#1509
We tried to simply unpack the `tuple_of_iterator_references`, however, if it contained nested `tuple_of_iterator_references` then that would break down. Instead recursively apply the unwrapping when possible
griwes
approved these changes
Mar 7, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to simply unpack the
tuple_of_iterator_references, however, if it contained nestedtuple_of_iterator_referencesthen that would break down. Instead recursively apply the unwrapping when possibleFixes #1467