Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try harder to unwrap nested thrust::tuple_of_iterator_references #1469

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Try harder to unwrap nested thrust::tuple_of_iterator_references #1469

merged 6 commits into from
Mar 7, 2024

Commits on Mar 7, 2024

  1. Ensure that we play nicely with std::iterators 

    We were defining our own set of iterator categories

That meant that an interator that is a `std::random_access_iterator` would not be a `cuda::std::random_access_iterator`

To ensure that we are playing nicely with iterators that use `std::` iterator categories just pull in the standard ones.

Fixes [BUG]: cuda::std::iterator_traits does not expose proper member types in old C++ dialects NVIDIA#1509
    @miscco
    miscco committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f7abbfb View commit details
    Browse the repository at this point in the history

  2. Ensure that we provide our own std::contiguous_iterator_tag if needed

    @miscco
    miscco committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8aa5886 View commit details
    Browse the repository at this point in the history

  3. Disable MSVC warning

    @miscco
    miscco committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c9270c5 View commit details
    Browse the repository at this point in the history

  4. Try to appease MSVC2017

    @miscco
    miscco committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5589946 View commit details
    Browse the repository at this point in the history

  5. Try harder to unwrap nested thrust::tuple_of_iterator_references 

    We tried to simply unpack the `tuple_of_iterator_references`, however, if it contained nested `tuple_of_iterator_references` then that would break down. Instead recursively apply the unwrapping when possible
    @miscco
    miscco committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    435ed8e View commit details
    Browse the repository at this point in the history

  6. Make tuple constructible from tuple_of_iterator_references

    @miscco
    miscco committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    1092932 View commit details
    Browse the repository at this point in the history