Make libcudacxx's codegen part of CI and add it to the project. #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
changed the title
wmaxey
force-pushed
the
fea/libcudacxx_codegen_enhancements
branch
from
f416970
to
73112ea
Compare
griwes
approved these changes
Mar 8, 2024
miscco
approved these changes
Mar 9, 2024
miscco
reviewed
Mar 9, 2024
Comment on lines
+180
to
+183
| sudo apt-get update | ||
| sudo apt-get install ninja-build | ||
| export CXX="g++" | ||
| ./ci/verify_codegen.sh |
There was a problem hiding this comment.
No need to change, but could we just run this in one of the devcontainers?
There was a problem hiding this comment.
It'd need to download the devcontainer, and we don't need the CTK. Running the verification steps locally are basically instant because everything is turned off.
Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of: #1424
Checklist