Ensure that we can run reduce_by_key with const inputs
#1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that explicitly passing in `thrust::device` was key here, otherwise the bug did not manifest Fixes [BUG]: `reduce_by_key` fails with zip_iterator to const pointers NVIDIA#1527
miscco
force-pushed
the
fix_thrust_zip_iterator_reduce_by_key
branch
from
6e3b0f2
to
f2eed72
Compare
The explicit usage of `int` can give a conversion warning, so just use the right difference type
wmaxey
reviewed
Mar 11, 2024
wmaxey
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that explicitly passing in
thrust::devicewas key here, otherwise the bug did not manifestFixes [BUG]:
reduce_by_keyfails with zip_iterator to const pointers #1527