Some cleanup in Thrust config headers #1934

bernhardmgruber · 2024-07-03T10:48:37Z

This PR proses some cleanup in the Thrust config headers:

Remove unused debug.h
Re-enable warning on obsolete memory fences
Remove an obsolete comment
Drop THRUST_TRAILING_RETURN

bernhardmgruber · 2024-07-03T11:57:48Z

I see this errors in the CI:

-- rapids-cmake [CCCL]: failed to apply diff revert_pr_211.diffrapids-cmake [CCCL]: git diff output: error: patch failed: thrust/thrust/system/cuda/detail/internal/copy_device_to_device.h:53
-- error: thrust/thrust/system/cuda/detail/internal/copy_device_to_device.h: patch does not apply

But I fail to find the file revert_pr_211.diff. Where is this coming from?

jrhemstad · 2024-07-03T14:15:07Z

I see this errors in the CI:

-- rapids-cmake [CCCL]: failed to apply diff revert_pr_211.diffrapids-cmake [CCCL]: git diff output: error: patch failed: thrust/thrust/system/cuda/detail/internal/copy_device_to_device.h:53
-- error: thrust/thrust/system/cuda/detail/internal/copy_device_to_device.h: patch does not apply

But I fail to find the file revert_pr_211.diff. Where is this coming from?

This is from our thirdparty RAPIDS build in CI.

RAPIDS applies some patches to Thrust source files as part of their build. Some of the changes here must conflict with one of their patch files.

We don't need to block merging this PR based on this failure, but we should let @robertmaynard @trxcllnt @bdice know so they can update the necessary patch files.

robertmaynard · 2024-07-03T14:30:26Z

I see this errors in the CI:
-- rapids-cmake [CCCL]: failed to apply diff revert_pr_211.diffrapids-cmake [CCCL]: git diff output: error: patch failed: thrust/thrust/system/cuda/detail/internal/copy_device_to_device.h:53
-- error: thrust/thrust/system/cuda/detail/internal/copy_device_to_device.h: patch does not apply
But I fail to find the file revert_pr_211.diff. Where is this coming from?
This is from our thirdparty RAPIDS build in CI.

RAPIDS applies some patches to Thrust source files as part of their build. Some of the changes here must conflict with one of their patch files.

We don't need to block merging this PR based on this failure, but we should let @robertmaynard @trxcllnt @bdice know so they can update the necessary patch files.

https://github.com/rapidsai/rapids-cmake/blob/branch-24.08/rapids-cmake/cpm/patches/cccl/revert_pr_211.diff is the change we are applying. I don't see this PR changing copy_device_to_device.h so I expect the issue is that #1915 broke our patch and now each RAPIDS project will fail to apply the patch

bernhardmgruber · 2024-07-03T14:40:16Z

@robertmaynard thank you for the answer! I am surprised this was not caught by the CI for the offending PR. In any case, please update your patch file then! Thx!

robertmaynard · 2024-07-03T15:02:13Z

@robertmaynard thank you for the answer! I am surprised this was not caught by the CI for the offending PR. In any case, please update your patch file then! Thx!

The rapids-cmake patch file can't be naively updated as we pull a specific SHA1 and that would cause the patch to fail with our SHA1.

That better option is to have the rapids ci jobs in CCCL updated to use an updated patch file ( https://github.com/NVIDIA/cccl/blob/main/ci/rapids/post-create-command.sh#L54 )

github-actions · 2024-07-03T16:11:32Z

🟨 CI finished in 5h 21m: Pass: 98%/249 | Total: 5d 00h | Avg: 28m 55s | Max: 1h 04m | Hits: 42%/245883

🟨 cub: Pass: 97%/131 | Total: 2d 18h | Avg: 30m 31s | Max: 55m 29s | Hits: 56%/106617

🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  97%/123 | Total:  2d 13h | Avg: 30m 14s | Max: 55m 29s | Hits:  56%/99801 
  🟩 arm64              Pass: 100%/8   | Total:  4h 39m | Avg: 34m 54s | Max: 38m 34s | Hits:  42%/6816  
🔍 ctk: 12.4 🔍
  🟩 11.1               Pass: 100%/15  | Total:  7h 31m | Avg: 30m 07s | Max: 46m 56s | Hits:  41%/11568 
  🟩 11.8               Pass: 100%/3   | Total:  2h 15m | Avg: 45m 13s | Max: 47m 26s | Hits:  42%/2556  
  🔍 12.4               Pass:  97%/113 | Total:  2d 08h | Avg: 30m 11s | Max: 55m 29s | Hits:  58%/92493 
🔍 cudacxx: nvcc12.4 🔍
  🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 22s | Avg:  3m 41s | Max:  3m 44s | Hits: 100%/1408  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  7h 31m | Avg: 30m 07s | Max: 46m 56s | Hits:  41%/11568 
  🟩 nvcc11.8           Pass: 100%/3   | Total:  2h 15m | Avg: 45m 13s | Max: 47m 26s | Hits:  42%/2556  
  🔍 nvcc12.4           Pass:  97%/111 | Total:  2d 08h | Avg: 30m 39s | Max: 55m 29s | Hits:  57%/91085 
🔍 cudacxx_family: nvcc 🔍
  🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 22s | Avg:  3m 41s | Max:  3m 44s | Hits: 100%/1408  
  🔍 nvcc               Pass:  97%/129 | Total:  2d 18h | Avg: 30m 56s | Max: 55m 29s | Hits:  55%/105209
🟨 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  3h 03m | Avg: 30m 33s | Max: 34m 01s | Hits:  42%/4890  
  🟩 Clang10            Pass: 100%/3   | Total:  1h 41m | Avg: 33m 46s | Max: 34m 42s | Hits:  43%/2562  
  🟩 Clang11            Pass: 100%/4   | Total:  2h 19m | Avg: 34m 45s | Max: 38m 57s | Hits:  43%/3416  
  🟩 Clang12            Pass: 100%/4   | Total:  2h 15m | Avg: 33m 55s | Max: 35m 13s | Hits:  43%/3416  
  🟩 Clang13            Pass: 100%/4   | Total:  2h 15m | Avg: 33m 45s | Max: 35m 33s | Hits:  43%/3416  
  🟩 Clang14            Pass: 100%/4   | Total:  2h 18m | Avg: 34m 36s | Max: 36m 43s | Hits:  43%/3416  
  🟩 Clang15            Pass: 100%/4   | Total:  2h 16m | Avg: 34m 02s | Max: 35m 23s | Hits:  43%/3408  
  🟩 Clang16            Pass: 100%/4   | Total:  2h 13m | Avg: 33m 26s | Max: 35m 09s | Hits:  43%/3408  
  🟨 Clang17            Pass:  96%/26  | Total:  9h 56m | Avg: 22m 55s | Max: 34m 32s | Hits:  81%/21004 
  🟩 GCC6               Pass: 100%/2   | Total: 57m 35s | Avg: 28m 47s | Max: 29m 21s | Hits:  40%/1552  
  🟩 GCC7               Pass: 100%/6   | Total:  3h 10m | Avg: 31m 44s | Max: 36m 00s | Hits:  41%/4893  
  🟩 GCC8               Pass: 100%/6   | Total:  3h 11m | Avg: 31m 54s | Max: 37m 31s | Hits:  41%/4893  
  🟩 GCC9               Pass: 100%/6   | Total:  3h 14m | Avg: 32m 29s | Max: 35m 19s | Hits:  41%/4893  
  🟩 GCC10              Pass: 100%/4   | Total:  2h 20m | Avg: 35m 06s | Max: 38m 28s | Hits:  42%/3416  
  🟩 GCC11              Pass: 100%/7   | Total:  4h 32m | Avg: 38m 53s | Max: 47m 26s | Hits:  42%/5964  
  🟩 GCC12              Pass: 100%/4   | Total:  2h 22m | Avg: 35m 42s | Max: 37m 03s | Hits:  42%/3408  
  🟨 GCC13              Pass:  92%/28  | Total: 11h 59m | Avg: 25m 41s | Max: 55m 29s | Hits:  70%/22152 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  1h 52m | Avg: 37m 26s | Max: 38m 06s | Hits:  41%/2340  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 46m 56s | Avg: 46m 56s | Max: 46m 56s | Hits:  43%/695   
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 31m | Avg: 45m 38s | Max: 45m 56s | Hits:  43%/1390  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 19m | Avg: 46m 36s | Max: 49m 12s | Hits:  43%/2085  
🟨 cxx_family
  🟨 Clang              Pass:  98%/59  | Total:  1d 04h | Avg: 28m 47s | Max: 38m 57s | Hits:  59%/48936 
  🟨 GCC                Pass:  96%/63  | Total:  1d 07h | Avg: 30m 18s | Max: 55m 29s | Hits:  54%/51171 
  🟩 Intel              Pass: 100%/3   | Total:  1h 52m | Avg: 37m 26s | Max: 38m 06s | Hits:  41%/2340  
  🟩 MSVC               Pass: 100%/6   | Total:  4h 38m | Avg: 46m 20s | Max: 49m 12s | Hits:  43%/4170  
🟨 jobs
  🟩 Build              Pass: 100%/99  | Total:  2d 07h | Avg: 33m 31s | Max: 49m 12s | Hits:  43%/81909 
  🟨 DeviceLaunch       Pass:  75%/8   | Total:  2h 41m | Avg: 20m 14s | Max: 55m 29s | Hits:  93%/5112  
  🟨 GraphCapture       Pass:  87%/8   | Total:  2h 03m | Avg: 15m 23s | Max: 20m 25s | Hits:  99%/5964  
  🟩 HostLaunch         Pass: 100%/8   | Total:  2h 24m | Avg: 18m 01s | Max: 22m 31s | Hits:  99%/6816  
  🟩 TestGPU            Pass: 100%/8   | Total:  4h 09m | Avg: 31m 13s | Max: 54m 04s | Hits:  94%/6816  
🟨 std
  🟨 11                 Pass:  97%/34  | Total: 17h 10m | Avg: 30m 17s | Max: 55m 29s | Hits:  53%/27687 
  🟩 14                 Pass: 100%/37  | Total: 19h 56m | Avg: 32m 21s | Max: 54m 04s | Hits:  54%/30624 
  🟩 17                 Pass: 100%/36  | Total: 18h 28m | Avg: 30m 48s | Max: 45m 56s | Hits:  57%/29857 
  🟨 20                 Pass:  91%/24  | Total: 11h 02m | Avg: 27m 36s | Max: 47m 04s | Hits:  60%/18449 
🟨 gpu
  🟨 v100               Pass:  97%/131 | Total:  2d 18h | Avg: 30m 31s | Max: 55m 29s | Hits:  56%/106617
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  2h 15m | Avg: 45m 13s | Max: 47m 26s | Hits:  42%/2556  
  🟩 90a                Pass: 100%/4   | Total:  1h 14m | Avg: 18m 42s | Max: 19m 07s | Hits:  42%/3408

🟩 thrust: Pass: 100%/118 | Total: 2d 05h | Avg: 27m 09s | Max: 1h 04m | Hits: 32%/139266

🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total:  2d 01h | Avg: 27m 08s | Max:  1h 04m | Hits:  32%/129822
  🟩 arm64              Pass: 100%/8   | Total:  3h 39m | Avg: 27m 26s | Max: 31m 35s | Hits:  30%/9444  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  7h 04m | Avg: 28m 17s | Max: 55m 49s | Hits:   4%/17705 
  🟩 11.8               Pass: 100%/3   | Total:  1h 55m | Avg: 38m 27s | Max: 41m 43s | Hits:   2%/3543  
  🟩 12.4               Pass: 100%/100 | Total:  1d 20h | Avg: 26m 39s | Max:  1h 04m | Hits:  37%/118018
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 31s | Avg:  3m 45s | Max:  3m 49s | Hits: 100%/2360  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  7h 04m | Avg: 28m 17s | Max: 55m 49s | Hits:   4%/17705 
  🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 55m | Avg: 38m 27s | Max: 41m 43s | Hits:   2%/3543  
  🟩 nvcc12.4           Pass: 100%/98  | Total:  1d 20h | Avg: 27m 07s | Max:  1h 04m | Hits:  36%/115658
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 31s | Avg:  3m 45s | Max:  3m 49s | Hits: 100%/2360  
  🟩 nvcc               Pass: 100%/116 | Total:  2d 05h | Avg: 27m 34s | Max:  1h 04m | Hits:  31%/136906
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  2h 52m | Avg: 28m 45s | Max: 32m 52s | Hits:   2%/7080  
  🟩 Clang10            Pass: 100%/3   | Total:  1h 34m | Avg: 31m 30s | Max: 33m 57s | Hits:   2%/3540  
  🟩 Clang11            Pass: 100%/4   | Total:  2h 01m | Avg: 30m 23s | Max: 30m 50s | Hits:   1%/4720  
  🟩 Clang12            Pass: 100%/4   | Total:  1h 58m | Avg: 29m 39s | Max: 31m 32s | Hits:   1%/4720  
  🟩 Clang13            Pass: 100%/4   | Total:  1h 57m | Avg: 29m 21s | Max: 31m 41s | Hits:   1%/4720  
  🟩 Clang14            Pass: 100%/4   | Total:  1h 41m | Avg: 25m 27s | Max: 27m 13s | Hits:  58%/4720  
  🟩 Clang15            Pass: 100%/4   | Total:  1h 42m | Avg: 25m 33s | Max: 27m 24s | Hits:  58%/4720  
  🟩 Clang16            Pass: 100%/4   | Total:  1h 48m | Avg: 27m 12s | Max: 28m 59s | Hits:  58%/4720  
  🟩 Clang17            Pass: 100%/18  | Total:  4h 49m | Avg: 16m 05s | Max: 28m 53s | Hits:  81%/21240 
  🟩 GCC6               Pass: 100%/2   | Total: 35m 03s | Avg: 17m 31s | Max: 27m 03s | Hits:  20%/2360  
  🟩 GCC7               Pass: 100%/6   | Total:  2h 49m | Avg: 28m 12s | Max: 32m 35s | Hits:   2%/7086  
  🟩 GCC8               Pass: 100%/6   | Total:  2h 55m | Avg: 29m 12s | Max: 32m 40s | Hits:   2%/7086  
  🟩 GCC9               Pass: 100%/6   | Total:  3h 02m | Avg: 30m 27s | Max: 37m 33s | Hits:   2%/7086  
  🟩 GCC10              Pass: 100%/4   | Total:  2h 09m | Avg: 32m 15s | Max: 34m 35s | Hits:   1%/4724  
  🟩 GCC11              Pass: 100%/7   | Total:  3h 46m | Avg: 32m 18s | Max: 41m 43s | Hits:  26%/8267  
  🟩 GCC12              Pass: 100%/4   | Total:  2h 07m | Avg: 31m 55s | Max: 35m 07s | Hits:   1%/4724  
  🟩 GCC13              Pass: 100%/20  | Total:  6h 24m | Avg: 19m 12s | Max: 31m 35s | Hits:  52%/23620 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  2h 13m | Avg: 44m 38s | Max: 50m 29s | Hits:   2%/3549  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 55m 49s | Avg: 55m 49s | Max: 55m 49s | Hits:   0%/1176  
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 55m | Avg: 57m 46s | Max: 58m 03s | Hits:   0%/2352  
  🟩 MSVC14.39          Pass: 100%/6   | Total:  4h 04m | Avg: 40m 41s | Max:  1h 04m | Hits:  49%/7056  
🟩 cxx_family
  🟩 Clang              Pass: 100%/51  | Total: 20h 27m | Avg: 24m 03s | Max: 33m 57s | Hits:  43%/60180 
  🟩 GCC                Pass: 100%/55  | Total: 23h 49m | Avg: 25m 59s | Max: 41m 43s | Hits:  24%/64953 
  🟩 Intel              Pass: 100%/3   | Total:  2h 13m | Avg: 44m 38s | Max: 50m 29s | Hits:   2%/3549  
  🟩 MSVC               Pass: 100%/9   | Total:  6h 55m | Avg: 46m 09s | Max:  1h 04m | Hits:  33%/10584 
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total:  2d 05h | Avg: 27m 09s | Max:  1h 04m | Hits:  32%/139266
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  2d 01h | Avg: 30m 10s | Max:  1h 04m | Hits:  19%/116850
  🟩 TestCPU            Pass: 100%/11  | Total:  1h 47m | Avg:  9m 45s | Max: 21m 08s | Hits:  99%/12972 
  🟩 TestGPU            Pass: 100%/8   | Total:  1h 50m | Avg: 13m 47s | Max: 17m 29s | Hits:  99%/9444  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 55m | Avg: 38m 27s | Max: 41m 43s | Hits:   2%/3543  
  🟩 90a                Pass: 100%/4   | Total:  1h 17m | Avg: 19m 28s | Max: 21m 17s | Hits:   1%/4724  
🟩 std
  🟩 11                 Pass: 100%/30  | Total: 11h 20m | Avg: 22m 40s | Max: 37m 04s | Hits:  30%/35418 
  🟩 14                 Pass: 100%/34  | Total: 16h 50m | Avg: 29m 42s | Max:  1h 00m | Hits:  27%/40122 
  🟩 17                 Pass: 100%/33  | Total: 16h 08m | Avg: 29m 20s | Max: 59m 03s | Hits:  31%/38946 
  🟩 20                 Pass: 100%/21  | Total:  9h 07m | Avg: 26m 03s | Max:  1h 04m | Hits:  45%/24780

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
+/-	Thrust
	CUDA Experimental

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental

🏃‍ Runner counts (total jobs: 249)

#	Runner
178	`linux-amd64-cpu16`
40	`linux-amd64-gpu-v100-latest-1`
16	`linux-arm64-cpu16`
15	`windows-amd64-cpu16`

github-actions · 2024-07-03T17:21:03Z

🟩 CI finished in 6h 30m: Pass: 100%/249 | Total: 5d 01h | Avg: 29m 12s | Max: 1h 04m | Hits: 43%/248439

🟩 cub: Pass: 100%/131 | Total: 2d 19h | Avg: 31m 02s | Max: 55m 29s | Hits: 56%/109173

🟩 cpu
  🟩 amd64              Pass: 100%/123 | Total:  2d 15h | Avg: 30m 47s | Max: 55m 29s | Hits:  57%/102357
  🟩 arm64              Pass: 100%/8   | Total:  4h 39m | Avg: 34m 54s | Max: 38m 34s | Hits:  42%/6816  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  7h 31m | Avg: 30m 07s | Max: 46m 56s | Hits:  41%/11568 
  🟩 11.8               Pass: 100%/3   | Total:  2h 15m | Avg: 45m 13s | Max: 47m 26s | Hits:  42%/2556  
  🟩 12.4               Pass: 100%/113 | Total:  2d 09h | Avg: 30m 47s | Max: 55m 29s | Hits:  59%/95049 
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 22s | Avg:  3m 41s | Max:  3m 44s | Hits: 100%/1408  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  7h 31m | Avg: 30m 07s | Max: 46m 56s | Hits:  41%/11568 
  🟩 nvcc11.8           Pass: 100%/3   | Total:  2h 15m | Avg: 45m 13s | Max: 47m 26s | Hits:  42%/2556  
  🟩 nvcc12.4           Pass: 100%/111 | Total:  2d 09h | Avg: 31m 16s | Max: 55m 29s | Hits:  58%/93641 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 22s | Avg:  3m 41s | Max:  3m 44s | Hits: 100%/1408  
  🟩 nvcc               Pass: 100%/129 | Total:  2d 19h | Avg: 31m 28s | Max: 55m 29s | Hits:  56%/107765
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  3h 03m | Avg: 30m 33s | Max: 34m 01s | Hits:  42%/4890  
  🟩 Clang10            Pass: 100%/3   | Total:  1h 41m | Avg: 33m 46s | Max: 34m 42s | Hits:  43%/2562  
  🟩 Clang11            Pass: 100%/4   | Total:  2h 19m | Avg: 34m 45s | Max: 38m 57s | Hits:  43%/3416  
  🟩 Clang12            Pass: 100%/4   | Total:  2h 15m | Avg: 33m 55s | Max: 35m 13s | Hits:  43%/3416  
  🟩 Clang13            Pass: 100%/4   | Total:  2h 15m | Avg: 33m 45s | Max: 35m 33s | Hits:  43%/3416  
  🟩 Clang14            Pass: 100%/4   | Total:  2h 18m | Avg: 34m 36s | Max: 36m 43s | Hits:  43%/3416  
  🟩 Clang15            Pass: 100%/4   | Total:  2h 16m | Avg: 34m 02s | Max: 35m 23s | Hits:  43%/3408  
  🟩 Clang16            Pass: 100%/4   | Total:  2h 13m | Avg: 33m 26s | Max: 35m 09s | Hits:  43%/3408  
  🟩 Clang17            Pass: 100%/26  | Total: 10h 09m | Avg: 23m 26s | Max: 34m 32s | Hits:  82%/21856 
  🟩 GCC6               Pass: 100%/2   | Total: 57m 35s | Avg: 28m 47s | Max: 29m 21s | Hits:  40%/1552  
  🟩 GCC7               Pass: 100%/6   | Total:  3h 10m | Avg: 31m 44s | Max: 36m 00s | Hits:  41%/4893  
  🟩 GCC8               Pass: 100%/6   | Total:  3h 11m | Avg: 31m 54s | Max: 37m 31s | Hits:  41%/4893  
  🟩 GCC9               Pass: 100%/6   | Total:  3h 14m | Avg: 32m 29s | Max: 35m 19s | Hits:  41%/4893  
  🟩 GCC10              Pass: 100%/4   | Total:  2h 20m | Avg: 35m 06s | Max: 38m 28s | Hits:  42%/3416  
  🟩 GCC11              Pass: 100%/7   | Total:  4h 32m | Avg: 38m 53s | Max: 47m 26s | Hits:  42%/5964  
  🟩 GCC12              Pass: 100%/4   | Total:  2h 22m | Avg: 35m 42s | Max: 37m 03s | Hits:  42%/3408  
  🟩 GCC13              Pass: 100%/28  | Total: 12h 54m | Avg: 27m 39s | Max: 55m 29s | Hits:  70%/23856 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  1h 52m | Avg: 37m 26s | Max: 38m 06s | Hits:  41%/2340  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 46m 56s | Avg: 46m 56s | Max: 46m 56s | Hits:  43%/695   
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 31m | Avg: 45m 38s | Max: 45m 56s | Hits:  43%/1390  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 19m | Avg: 46m 36s | Max: 49m 12s | Hits:  43%/2085  
🟩 cxx_family
  🟩 Clang              Pass: 100%/59  | Total:  1d 04h | Avg: 29m 01s | Max: 38m 57s | Hits:  60%/49788 
  🟩 GCC                Pass: 100%/63  | Total:  1d 08h | Avg: 31m 10s | Max: 55m 29s | Hits:  55%/52875 
  🟩 Intel              Pass: 100%/3   | Total:  1h 52m | Avg: 37m 26s | Max: 38m 06s | Hits:  41%/2340  
  🟩 MSVC               Pass: 100%/6   | Total:  4h 38m | Avg: 46m 20s | Max: 49m 12s | Hits:  43%/4170  
🟩 gpu
  🟩 v100               Pass: 100%/131 | Total:  2d 19h | Avg: 31m 02s | Max: 55m 29s | Hits:  56%/109173
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  2d 07h | Avg: 33m 31s | Max: 49m 12s | Hits:  43%/81909 
  🟩 DeviceLaunch       Pass: 100%/8   | Total:  3h 11m | Avg: 23m 57s | Max: 55m 29s | Hits:  94%/6816  
  🟩 GraphCapture       Pass: 100%/8   | Total:  2h 41m | Avg: 20m 13s | Max: 44m 33s | Hits:  94%/6816  
  🟩 HostLaunch         Pass: 100%/8   | Total:  2h 24m | Avg: 18m 01s | Max: 22m 31s | Hits:  99%/6816  
  🟩 TestGPU            Pass: 100%/8   | Total:  4h 09m | Avg: 31m 13s | Max: 54m 04s | Hits:  94%/6816  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  2h 15m | Avg: 45m 13s | Max: 47m 26s | Hits:  42%/2556  
  🟩 90a                Pass: 100%/4   | Total:  1h 14m | Avg: 18m 42s | Max: 19m 07s | Hits:  42%/3408  
🟩 std
  🟩 11                 Pass: 100%/34  | Total: 17h 23m | Avg: 30m 41s | Max: 55m 29s | Hits:  55%/28539 
  🟩 14                 Pass: 100%/37  | Total: 19h 56m | Avg: 32m 21s | Max: 54m 04s | Hits:  54%/30624 
  🟩 17                 Pass: 100%/36  | Total: 18h 28m | Avg: 30m 48s | Max: 45m 56s | Hits:  57%/29857 
  🟩 20                 Pass: 100%/24  | Total: 11h 57m | Avg: 29m 53s | Max: 47m 04s | Hits:  62%/20153

🟩 thrust: Pass: 100%/118 | Total: 2d 05h | Avg: 27m 09s | Max: 1h 04m | Hits: 32%/139266

🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total:  2d 01h | Avg: 27m 08s | Max:  1h 04m | Hits:  32%/129822
  🟩 arm64              Pass: 100%/8   | Total:  3h 39m | Avg: 27m 26s | Max: 31m 35s | Hits:  30%/9444  
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  7h 04m | Avg: 28m 17s | Max: 55m 49s | Hits:   4%/17705 
  🟩 11.8               Pass: 100%/3   | Total:  1h 55m | Avg: 38m 27s | Max: 41m 43s | Hits:   2%/3543  
  🟩 12.4               Pass: 100%/100 | Total:  1d 20h | Avg: 26m 39s | Max:  1h 04m | Hits:  37%/118018
🟩 cudacxx
  🟩 ClangCUDA17        Pass: 100%/2   | Total:  7m 31s | Avg:  3m 45s | Max:  3m 49s | Hits: 100%/2360  
  🟩 nvcc11.1           Pass: 100%/15  | Total:  7h 04m | Avg: 28m 17s | Max: 55m 49s | Hits:   4%/17705 
  🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 55m | Avg: 38m 27s | Max: 41m 43s | Hits:   2%/3543  
  🟩 nvcc12.4           Pass: 100%/98  | Total:  1d 20h | Avg: 27m 07s | Max:  1h 04m | Hits:  36%/115658
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  7m 31s | Avg:  3m 45s | Max:  3m 49s | Hits: 100%/2360  
  🟩 nvcc               Pass: 100%/116 | Total:  2d 05h | Avg: 27m 34s | Max:  1h 04m | Hits:  31%/136906
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  2h 52m | Avg: 28m 45s | Max: 32m 52s | Hits:   2%/7080  
  🟩 Clang10            Pass: 100%/3   | Total:  1h 34m | Avg: 31m 30s | Max: 33m 57s | Hits:   2%/3540  
  🟩 Clang11            Pass: 100%/4   | Total:  2h 01m | Avg: 30m 23s | Max: 30m 50s | Hits:   1%/4720  
  🟩 Clang12            Pass: 100%/4   | Total:  1h 58m | Avg: 29m 39s | Max: 31m 32s | Hits:   1%/4720  
  🟩 Clang13            Pass: 100%/4   | Total:  1h 57m | Avg: 29m 21s | Max: 31m 41s | Hits:   1%/4720  
  🟩 Clang14            Pass: 100%/4   | Total:  1h 41m | Avg: 25m 27s | Max: 27m 13s | Hits:  58%/4720  
  🟩 Clang15            Pass: 100%/4   | Total:  1h 42m | Avg: 25m 33s | Max: 27m 24s | Hits:  58%/4720  
  🟩 Clang16            Pass: 100%/4   | Total:  1h 48m | Avg: 27m 12s | Max: 28m 59s | Hits:  58%/4720  
  🟩 Clang17            Pass: 100%/18  | Total:  4h 49m | Avg: 16m 05s | Max: 28m 53s | Hits:  81%/21240 
  🟩 GCC6               Pass: 100%/2   | Total: 35m 03s | Avg: 17m 31s | Max: 27m 03s | Hits:  20%/2360  
  🟩 GCC7               Pass: 100%/6   | Total:  2h 49m | Avg: 28m 12s | Max: 32m 35s | Hits:   2%/7086  
  🟩 GCC8               Pass: 100%/6   | Total:  2h 55m | Avg: 29m 12s | Max: 32m 40s | Hits:   2%/7086  
  🟩 GCC9               Pass: 100%/6   | Total:  3h 02m | Avg: 30m 27s | Max: 37m 33s | Hits:   2%/7086  
  🟩 GCC10              Pass: 100%/4   | Total:  2h 09m | Avg: 32m 15s | Max: 34m 35s | Hits:   1%/4724  
  🟩 GCC11              Pass: 100%/7   | Total:  3h 46m | Avg: 32m 18s | Max: 41m 43s | Hits:  26%/8267  
  🟩 GCC12              Pass: 100%/4   | Total:  2h 07m | Avg: 31m 55s | Max: 35m 07s | Hits:   1%/4724  
  🟩 GCC13              Pass: 100%/20  | Total:  6h 24m | Avg: 19m 12s | Max: 31m 35s | Hits:  52%/23620 
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  2h 13m | Avg: 44m 38s | Max: 50m 29s | Hits:   2%/3549  
  🟩 MSVC14.16          Pass: 100%/1   | Total: 55m 49s | Avg: 55m 49s | Max: 55m 49s | Hits:   0%/1176  
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 55m | Avg: 57m 46s | Max: 58m 03s | Hits:   0%/2352  
  🟩 MSVC14.39          Pass: 100%/6   | Total:  4h 04m | Avg: 40m 41s | Max:  1h 04m | Hits:  49%/7056  
🟩 cxx_family
  🟩 Clang              Pass: 100%/51  | Total: 20h 27m | Avg: 24m 03s | Max: 33m 57s | Hits:  43%/60180 
  🟩 GCC                Pass: 100%/55  | Total: 23h 49m | Avg: 25m 59s | Max: 41m 43s | Hits:  24%/64953 
  🟩 Intel              Pass: 100%/3   | Total:  2h 13m | Avg: 44m 38s | Max: 50m 29s | Hits:   2%/3549  
  🟩 MSVC               Pass: 100%/9   | Total:  6h 55m | Avg: 46m 09s | Max:  1h 04m | Hits:  33%/10584 
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total:  2d 05h | Avg: 27m 09s | Max:  1h 04m | Hits:  32%/139266
🟩 jobs
  🟩 Build              Pass: 100%/99  | Total:  2d 01h | Avg: 30m 10s | Max:  1h 04m | Hits:  19%/116850
  🟩 TestCPU            Pass: 100%/11  | Total:  1h 47m | Avg:  9m 45s | Max: 21m 08s | Hits:  99%/12972 
  🟩 TestGPU            Pass: 100%/8   | Total:  1h 50m | Avg: 13m 47s | Max: 17m 29s | Hits:  99%/9444  
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 55m | Avg: 38m 27s | Max: 41m 43s | Hits:   2%/3543  
  🟩 90a                Pass: 100%/4   | Total:  1h 17m | Avg: 19m 28s | Max: 21m 17s | Hits:   1%/4724  
🟩 std
  🟩 11                 Pass: 100%/30  | Total: 11h 20m | Avg: 22m 40s | Max: 37m 04s | Hits:  30%/35418 
  🟩 14                 Pass: 100%/34  | Total: 16h 50m | Avg: 29m 42s | Max:  1h 00m | Hits:  27%/40122 
  🟩 17                 Pass: 100%/33  | Total: 16h 08m | Avg: 29m 20s | Max: 59m 03s | Hits:  31%/38946 
  🟩 20                 Pass: 100%/21  | Total:  9h 07m | Avg: 26m 03s | Max:  1h 04m | Hits:  45%/24780

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
	CUB
+/-	Thrust
	CUDA Experimental

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental

🏃‍ Runner counts (total jobs: 249)

#	Runner
178	`linux-amd64-cpu16`
40	`linux-amd64-gpu-v100-latest-1`
16	`linux-arm64-cpu16`
15	`windows-amd64-cpu16`

bernhardmgruber added 4 commits July 3, 2024 12:27

Drop THRUST_TRAILING_RETURN

0ae6021

Remove obsolete comment

d49ed98

Re-enable warning on obsolete memory fences

3a2d18d

Remove unused debug.h

153ae1d

bernhardmgruber added the thrust For all items related to Thrust. label Jul 3, 2024

bernhardmgruber marked this pull request as ready for review July 3, 2024 14:38

bernhardmgruber requested review from a team as code owners July 3, 2024 14:38

bernhardmgruber requested review from alliepiper and griwes July 3, 2024 14:38

miscco approved these changes Jul 4, 2024

View reviewed changes

miscco merged commit d26b16f into NVIDIA:main Jul 4, 2024
261 of 264 checks passed

bernhardmgruber deleted the thrust_config branch July 4, 2024 08:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some cleanup in Thrust config headers #1934

Some cleanup in Thrust config headers #1934

bernhardmgruber commented Jul 3, 2024

bernhardmgruber commented Jul 3, 2024

jrhemstad commented Jul 3, 2024

robertmaynard commented Jul 3, 2024

bernhardmgruber commented Jul 3, 2024

robertmaynard commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

🟨 cub: Pass: 97%/131 | Total: 2d 18h | Avg: 30m 31s | Max: 55m 29s | Hits: 56%/106617

🟩 thrust: Pass: 100%/118 | Total: 2d 05h | Avg: 27m 09s | Max: 1h 04m | Hits: 32%/139266

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 249)

github-actions bot commented Jul 3, 2024

🟩 cub: Pass: 100%/131 | Total: 2d 19h | Avg: 31m 02s | Max: 55m 29s | Hits: 56%/109173

🟩 thrust: Pass: 100%/118 | Total: 2d 05h | Avg: 27m 09s | Max: 1h 04m | Hits: 32%/139266

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 249)

Some cleanup in Thrust config headers #1934

Some cleanup in Thrust config headers #1934

Conversation

bernhardmgruber commented Jul 3, 2024

bernhardmgruber commented Jul 3, 2024

jrhemstad commented Jul 3, 2024

robertmaynard commented Jul 3, 2024

bernhardmgruber commented Jul 3, 2024

robertmaynard commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

🟨 cub: Pass: 97%/131 | Total: 2d 18h | Avg: 30m 31s | Max: 55m 29s | Hits: 56%/106617

🟩 thrust: Pass: 100%/118 | Total: 2d 05h | Avg: 27m 09s | Max: 1h 04m | Hits: 32%/139266

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 249)

github-actions bot commented Jul 3, 2024

🟩 cub: Pass: 100%/131 | Total: 2d 19h | Avg: 31m 02s | Max: 55m 29s | Hits: 56%/109173

🟩 thrust: Pass: 100%/118 | Total: 2d 05h | Avg: 27m 09s | Max: 1h 04m | Hits: 32%/139266

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 249)