Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Support user defined CMAKE_INSTALL_INCLUDEDIR values #415

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Support user defined CMAKE_INSTALL_INCLUDEDIR values #415

merged 3 commits into from
Jan 12, 2022

Conversation

robertmaynard
Copy link
Collaborator

Needed to fix NVIDIA/thrust#1541

@robertmaynard robertmaynard added type: enhancement New feature or request. only: cmake CMake changes only. Doesn't need internal NVIDIA CI (DVS). labels Dec 17, 2021
@robertmaynard robertmaynard mentioned this pull request Dec 17, 2021
Merged
@alliepiper alliepiper self-requested a review December 17, 2021 17:43
@alliepiper alliepiper added helps: rapids Helps or needed by RAPIDS. P1: should have Necessary, but not critical. labels Dec 17, 2021
@alliepiper alliepiper added this to Inbox in PR Tracking via automation Dec 17, 2021
@alliepiper alliepiper added this to the 1.16.0 milestone Dec 17, 2021
@alliepiper alliepiper moved this from Inbox to Need Review in PR Tracking Dec 17, 2021
@robertmaynard robertmaynard changed the title Allow cub headers to be installed into a subdirectory of include Support user defined CMAKE_INSTALL_INCLUDEDIR values Dec 20, 2021
alliepiper
alliepiper suggested changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some minor style points mentioned inline, this looks good to me.

cmake/CubInstallRules.cmake Outdated Show resolved Hide resolved
cub/cmake/cub-header-search.cmake Outdated Show resolved Hide resolved
cmake/CubInstallRules.cmake Show resolved Hide resolved
cub/cmake/cub-config-version.cmake Outdated Show resolved Hide resolved
cub/cmake/cub-header-search.cmake Outdated Show resolved Hide resolved
cub/cmake/cub-header-search.cmake.in Outdated Show resolved Hide resolved
@alliepiper alliepiper moved this from Need Review to Drafts in PR Tracking Jan 10, 2022
@robertmaynard
Copy link
Collaborator Author

Aside from some minor style points mentioned inline, this looks good to me.

All style issues are now resolved.

@alliepiper alliepiper moved this from Drafts to Tests Pending in PR Tracking Jan 10, 2022
@alliepiper alliepiper merged commit 66e2be6 into NVIDIA:main Jan 12, 2022
PR Tracking automation moved this from Tests Pending to Done Jan 12, 2022
@robertmaynard robertmaynard deleted the cub_install_infix branch January 12, 2022 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

Assignees

@robertmaynard robertmaynard

Labels
helps: rapids Helps or needed by RAPIDS. only: cmake CMake changes only. Doesn't need internal NVIDIA CI (DVS). P1: should have Necessary, but not critical. type: enhancement New feature or request.
Projects
PR Tracking
Done
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Allow Thrust and CUB headers to be nested in a custom directory
2 participants
@robertmaynard @alliepiper