Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where qubits are retained with draw / tracer #1457

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Fix issue where qubits are retained with draw / tracer #1457

merged 3 commits into from
Apr 1, 2024

Conversation

amccaskey
Copy link
Collaborator

@amccaskey amccaskey commented Mar 28, 2024 •
edited
Loading

Fixes #1400

@amccaskey
Fix issue where qubits are retained with draw / tracer
de6ec5b 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 28, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey
Better approach
902f63d 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Mar 28, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
@cuda-quantum-bot
Docs preview for PR #1457.
21f6a80
@amccaskey
strengthen the test
39187af 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Mar 29, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
@cuda-quantum-bot
Docs preview for PR #1457.
34a76fd
@bmhowe23 bmhowe23 added the bug fix To be listed under Bug Fixes in the release notes label Apr 1, 2024
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Apr 1, 2024

This LGTM. I also downloaded the PR and manually added a test to the end of python/tests/kernel/test_kernel_features.py (as described in #1400 (comment)), and it also resolves that issue as expected, which is good 👍 .

@bmhowe23 bmhowe23 mentioned this pull request Apr 1, 2024
Merged
@amccaskey amccaskey merged commit f6840d0 into NVIDIA:main Apr 1, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
release 0.7.1
Development

Successfully merging this pull request may close these issues.

Circuit drawer retains qubits from previously printed kernel(s)
3 participants
@amccaskey @bmhowe23 @bettinaheim