Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error handling and bug fixes for Python #1458

Merged
merged 9 commits into from
Apr 1, 2024
Merged

Improved error handling and bug fixes for Python #1458

merged 9 commits into from
Apr 1, 2024

Conversation

amccaskey
Copy link
Collaborator

@amccaskey amccaskey commented Mar 28, 2024 •
edited
Loading

Fixes #1446
Fixes #1447
Fixes #1448
Fixes #1449
Fixes #1450
Fixes #1451

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 28, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey amccaskey changed the title Fix issue 1446 where bad attribute name was allowed Fix issues 1446 , 1447 Mar 28, 2024
@amccaskey amccaskey changed the title Fix issues 1446 , 1447 Fix issues 1446 , 1447, 1448, 1449, 1450 Mar 28, 2024
@amccaskey amccaskey marked this pull request as draft March 28, 2024 16:49
@amccaskey amccaskey changed the title Fix issues 1446 , 1447, 1448, 1449, 1450 Fix issues 1446-1451 Mar 28, 2024
@amccaskey amccaskey changed the title Fix issues 1446-1451 PyASTBridge Fixes - Issues 1446-1451 Mar 28, 2024
@amccaskey amccaskey marked this pull request as ready for review March 28, 2024 17:52
@amccaskey
Copy link
Collaborator Author

amccaskey commented Mar 28, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
@cuda-quantum-bot
Docs preview for PR #1458.
5992e77
@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 1, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey enabled auto-merge (squash) April 1, 2024 13:31
bmhowe23
bmhowe23 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+6

@bmhowe23 bmhowe23 added the bug fix To be listed under Bug Fixes in the release notes label Apr 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 1, 2024
@cuda-quantum-bot
Docs preview for PR #1458.
e427938
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 1, 2024
@cuda-quantum-bot
Docs preview for PR #1458.
fdf572d
@amccaskey
Fix issue 1446 where bad attribute name was allowed
c4ba293 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Fix 1447, better errors for bad qubit types
1b5b2c9 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Fix 1448, support math.pi
be6bf5c 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Fix 1449, support len on qvector
a026705 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Fix 1450, catch missing paren and throw error
26708e0 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Fix 1451, cast float to int for range()
15340c1 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
spell check
289ce8d 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
add some docstrings
4c395bd 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
address pr comments
61acbd9 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 1, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey merged commit c0fda69 into NVIDIA:main Apr 1, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
@bettinaheim bettinaheim changed the title PyASTBridge Fixes - Issues 1446-1451 Improved error handling and bug fixes for Python Apr 17, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
release 0.7.1
3 participants
@amccaskey @bmhowe23 @bettinaheim