Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nvidia resource names configurable #359

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

lx1036
Copy link
Contributor

@lx1036 lx1036 commented Jul 12, 2024

fix issue #314 , to make nvidia resource names configurable.

It can solve the problem that nvidia/k8s-device-plugin advertise specified GPU type like nvidia.com/a100 or nvidia.com/a10 and so on, not nvidia.com/gpu.

Copy link
Collaborator

@nvvfedorov nvvfedorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lx1036 and others added 2 commits July 13, 2024 22:06
Signed-off-by: lx1036 <lx1036@126.com>
Signed-off-by: Vadym Fedorov <vfedorov@nvidia.com>
@lx1036 lx1036 force-pushed the feature/configure-resource-names branch from 1cffcb5 to d834c10 Compare July 13, 2024 14:07
@lx1036
Copy link
Contributor Author

lx1036 commented Jul 13, 2024

@nvvfedorov have added a GPG signature to my commit. thanks for review.

@nvvfedorov nvvfedorov merged commit b4552f0 into NVIDIA:main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants