This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix atomic and barrier on NVRTC. #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
force-pushed
the
bugfix/atomic_nvrtc
branch
from
5a36617
to
32f88dd
Compare
griwes
approved these changes
Aug 10, 2021
Comment on lines
+100
to
+101
| #elif defined(_LIBCUDACXX_COMPILER_NVRTC) | ||
| # include "atomic_nvrtc.h" |
There was a problem hiding this comment.
Ooooh. It's because prior to the refactor, all the host bits were ifdef'd out, but now we depend on storage types and whatnot from __host? Makes sense.
There was a problem hiding this comment.
Right, we should make an abstraction for storage. I remember attempting to do that and finding it too difficult to remove the scope parameter in the same change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something in NVRTC has changed that requires a new method of querying if the barrier layout is messy.
Atomics are unable to select a proper backend when built with NVRTC. This is fixed with a stub include of what is in
atomic_base.h.