Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Increase contrast of search input text in docs. #258

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 20, 2022

This PR increases the contrast of the documentation's search bar text so that the input text is legible.

If this PR is approved/merged, I will make a similar PR to improve Thrust's documentation. If anyone is aware of other instances of this issue, let me know and I can make corresponding updates to other repositories.

Before:
image

After:
image

@wmaxey wmaxey self-assigned this Mar 20, 2022
@wmaxey wmaxey added the only: docs Documentation changes only. Doesn't need code CI. label Mar 20, 2022
@wmaxey
Copy link
Member

wmaxey commented Mar 20, 2022

I'll take a look and see if this is browser unique, I don't seem to encounter this on Chrome. In fact I have the opposite problem, the search pre-fill is legible while my query is black on grey and quite difficult to read.

@bdice
Copy link
Contributor Author

bdice commented Mar 20, 2022

Interesting observation, the default input colors may differ by browser (I saw this in Firefox). Setting a color in the CSS should hopefully fix the problem for all browsers. 😊

edit: I think this change will apply to both the pre-filled “Search libcu++” and user input, in all browsers.

@harrism
Copy link
Collaborator

harrism commented Mar 22, 2022

I definitely see the unreadable black on charcoal search box in Firefox. IMO we should get rid of the default black background website because it leads to usability issues. See also NVIDIA/cccl#942 .

@bdice
Copy link
Contributor Author

bdice commented Mar 22, 2022

Following up from the question about Chrome: I verified that this fix works for Firefox, Chrome, and Edge browsers. All three browsers show light text on a dark background in the placeholder text and when input is entered. Here's what it looks like when input is entered into the search box:
image

@wmaxey
Copy link
Member

wmaxey commented Mar 23, 2022

Thank you both for the feedback, I agree that the docs need a readability update, but at the moment that's somewhat beyond me. I'll take some time to find out if I can do it myself or bug Bryce about it.

@wmaxey wmaxey merged commit b15a6b0 into NVIDIA:main Mar 23, 2022
@wmaxey wmaxey added this to the 1.8.1 milestone Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
only: docs Documentation changes only. Doesn't need code CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants