This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Correct issues with CMake install rules #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install commands in cmake are only supported in project mode and therefore need to come after the `project` call.
robertmaynard
added
only: cmake
miscco
approved these changes
Nov 8, 2022
These CMakeLists.txt files aren't needed by consumers, and therefore shouldn't be installed.
|
Pipeline has been launched on Blossom. We'll know the results soon. |
Any update on this? |
Pipeline was having issues over the weekend and earlier. Tests are passing. LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects three issues found by
rapids-cmakeand others when trying to install libcudacxx.installcommands need to come afterproject. Theinstallcommands aren't allowed when in CMake scripting mode which is the mode you are in before the first call toproject()install(DIRECTORY PATTERN)matches the end of a file name, not the front so we need to use*.cmake.into notinstall the template files
libcudacxx_TOPLEVEL_PROJECTinstead ofLIBCUDACXX_TOPLEVEL_PROJECTso we never defaulted to have install rules enabled when building libcudacxx itself.include/cuda' orinclude/nv'