InfiniteSampler: don't pass dataset to super class #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/blossom-ci |
mnabian
approved these changes
May 24, 2024
NickGeneva
approved these changes
May 28, 2024
simonbyrne
force-pushed
the
sb/infinite-sampler-dataset-arg
branch
from
0e8a63c
to
ce67821
Compare
|
/blossom-ci |
This suppresses a printed warning: ``` UserWarning: `data_source` argument is not used and will be removed in 2.2.0.You may still have custom implementation that utilizes it. ```
simonbyrne
force-pushed
the
sb/infinite-sampler-dataset-arg
branch
from
ce67821
to
633d3e1
Compare
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
NickGeneva
added
the
5 - Ready to Merge
|
/blossom-ci |
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modulus Pull Request
Description
The
data_sourceargument totorch.utils.data.Samplerdoes nothing, and now triggers a warning if it is notNone.This change avoid passing it to the super class
__init__()function.Fixes #526
Checklist
Dependencies