-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align print format string for column names and units #126
base: master
Are you sure you want to change the base?
Conversation
I can't see any misalignment in my tests:
|
That's because you don't have any data corruption. In the case of corruption, we could have up to 6 chars I guess hence the change. If that is truly the idea, I agree it would be better. It's annoying to widen the line for something that should never happen, but if it happened, it would break any automatic parsing, including parsing supposed to report errors. |
this change aligns format string:
to make them identical: Line 553 in 2cbb968
Line 555 in 2cbb968
|
22de050
to
fd03a19
Compare
@AddyLaddy @sjeaugey could you review pls? |
The reason we replaced So I'm still not sure what problem we're trying to solve here. |
Format for column names and units started to be mismatched after changing "error" to "#wrong" in NCCL 2.13 (merged to master as a part of 51af557).