Disable word-wrapping when output is not a terminal #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue:
When redirecting nvidia-settings output to a file or a pipe (for simple
recording, or scripting purposes), we don't want the output to change
depending on the current terminal width (TIOCGWINSZ).
Fix/Feature:
This change disables word-wrapping of `nv_msg`/`nv_*_msg` functions when
the output stream is not a terminal (not `isatty`).
PRE-Merge Build Fix from Liam Middlebrook <lmiddlebrook@nvidia.com>:
Add _GNU_SOURCE define for fileno
liam-middlebrook
force-pushed
the
no-word-wrap
branch
from
7ce8119
to
636e81c
Compare
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvidia-settings seems to always word-wrap the output depending on the current terminal width. It's quite annoying when trying to redirect/pipe nvidia-settings' output for simple record keeping/diffing, simple task automation etc...
This PR shows a quick way to disable word-wrapping of
nv_msg/nv_*_msgfunctions when the output stream is not a terminal (notisatty).