Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement benchmark for get_json_object #1952

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Apr 10, 2024

This adds a benchmark for get_json_object which allows testing performance of the function with input having various nested levels.

Also fixes some compilation issues in the benchmark code.


Build benchmark

The build command is similar to this:

./build/build-in-docker clean install -DGPU_ARCHS=75 -DCPP_PARALLEL_LEVEL=16 -Dsubmodule.check.skip=true -DskipTests -DBUILD_BENCHMARKS=ON -DBUILD_TESTS=ON

Run benchmarks and compare

Run this before and after each code change:

./benchmarks/GET_JSON_OBJECT_BENCH --json <before|after>.json

Then compare (using nvbench_compare.py):

 python nvbench_compare.py before.json after.json

Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia ttnghia requested a review from res-life April 10, 2024 23:56
@ttnghia ttnghia self-assigned this Apr 10, 2024
@ttnghia
Copy link
Collaborator Author

ttnghia commented Apr 10, 2024

build

Signed-off-by: Nghia Truong <nghiat@nvidia.com>
@ttnghia
Copy link
Collaborator Author

ttnghia commented Apr 11, 2024

build

@res-life
Copy link
Collaborator

I compiled and tested sucessfully.
LGTM

@ttnghia ttnghia merged commit a4520a4 into NVIDIA:branch-24.06 Apr 16, 2024
3 checks passed
@ttnghia ttnghia deleted the bench_get_json branch April 16, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants