Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize from_unixtime #10000

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

res-life
Copy link
Collaborator

@res-life res-life commented Dec 8, 2023

contributes to #9605

GpuTimeZoneDB.fromUtcTimestampToTimestamp supports second timestamp, no need to convert to microsecond timestamp first.

Signed-off-by: Chong Gao res_life@163.com

Signed-off-by: Chong Gao <res_life@163.com>
@res-life
Copy link
Collaborator Author

res-life commented Dec 8, 2023

build

winningsix
winningsix previously approved these changes Dec 8, 2023
@res-life
Copy link
Collaborator Author

res-life commented Dec 8, 2023

build

Copy link
Collaborator

@NVnavkumar NVnavkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@razajafri razajafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sameerz sameerz added the performance A performance related task/issue label Dec 10, 2023
@res-life res-life merged commit c593338 into NVIDIA:branch-24.02 Dec 11, 2023
38 checks passed
@res-life res-life deleted the optimize-from-unixtime branch December 11, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance related task/issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants