Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config to enable mixed types as string in GpuJsonToStruct & GpuJsonScan #10268

Merged
merged 8 commits into from
Jan 27, 2024
Merged

Add config to enable mixed types as string in GpuJsonToStruct & GpuJsonScan #10268

merged 8 commits into from
Jan 27, 2024

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Jan 24, 2024 •
edited

Closes #10253

Changes in this PR:

@andygrove andygrove self-assigned this Jan 24, 2024
@andygrove andygrove changed the title WIP: Enable mixed types in GpuJsonToStruct Enable mixed types as string in GpuJsonToStruct Jan 25, 2024
@andygrove andygrove marked this pull request as ready for review January 25, 2024 19:11
@andygrove
Copy link
Contributor Author

build

@andygrove
Copy link
Contributor Author

build

jlowe
jlowe approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but we probably want to change the headline as it implies this is now enabled when it's actually disabled by default.

@jlowe
Copy link
Member

jlowe commented Jan 26, 2024

build

@andygrove andygrove changed the title Enable mixed types as string in GpuJsonToStruct Add config to enable mixed types as string in GpuJsonToStruct & GpuJsonScan Jan 26, 2024
@sameerz sameerz added the feature request New feature or request label Jan 26, 2024
@andygrove
Copy link
Contributor Author

Test failures with st_hash_grpby_sum

BlockManagerMaster: Failed to remove shuffle 11 - An executor with RapidsShuffleManager is trying to use a ShuffleBufferCatalog that isn't initialized.
2024-01-26T19:11:39.8073853Z [2024-01-26T19:09:27.685Z] java.lang.IllegalStateException: An executor with RapidsShuffleManager is trying to use a ShuffleBufferCatalog that isn't initialized.

@andygrove
Copy link
Contributor Author

build failing due to #10291

@andygrove
Copy link
Contributor Author

build

@andygrove andygrove merged commit 79c9029 into NVIDIA:branch-24.02 Jan 27, 2024
40 checks passed
@andygrove andygrove deleted the mixed-list-struct-from-json branch January 27, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 revans2 approved these changes

Assignees

@andygrove andygrove

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Enable mixed types as string in GpuJsonToStruct
4 participants
@andygrove @jlowe @revans2 @sameerz