Support reading JSON data with single quotes around attribute names and values #10273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
|
build |
jlowe
reviewed
Jan 26, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonToStructs.scala
Show resolved
Hide resolved
jlowe
previously approved these changes
Jan 26, 2024
|
build |
|
build failing due to #10291 |
revans2
previously approved these changes
Jan 26, 2024
|
build |
… into json-single-quote
|
build |
| @@ -599,7 +599,7 @@ def test_from_json_map_fallback(): | |||
| @allow_non_gpu(*non_utc_allow) | |||
| def test_from_json_struct(schema): | |||
| # note that column 'a' does not use leading zeroes due to https://github.com/NVIDIA/spark-rapids/issues/9588 | |||
| json_string_gen = StringGen(r'{"a": [1-9]{0,5}, "b": "[A-Z]{0,5}", "c": 1\d\d\d}') \ | |||
| json_string_gen = StringGen(r'{\'a\': [1-9]{0,5}, "b": \'[A-Z]{0,5}\', "c": 1\d\d\d}') \ | |||
There was a problem hiding this comment.
nit: could use fewer escape sequences with triple quotes
Suggested change
| json_string_gen = StringGen(r'{\'a\': [1-9]{0,5}, "b": \'[A-Z]{0,5}\', "c": 1\d\d\d}') \ | |
| json_string_gen = StringGen(r'''{'a': [1-9]{0,5}, "b": '[A-Z]{0,5}', "c": 1\d\d\d}''') \ |
There was a problem hiding this comment.
Makes sense. I will address this in a follow-up PR if that is ok since we need this to make it into the 24.02 release.
jlowe
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10270
Depends on rapidsai/cudf#14729