Fix performance regression in from_json #10306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
|
build |
andygrove
commented
Jan 29, 2024
| // join all the JSON lines into one string | ||
| val joined = withResource(withNewline) { _ => | ||
| withResource(Scalar.fromString("")) { emptyString => | ||
| withNewline.joinStrings(emptyString, emptyRow) |
There was a problem hiding this comment.
Note that the naRep parameter of emptyRow here is redundant since we already replaced nulls with emptyRow earlier in this code.
jlowe
approved these changes
Jan 29, 2024
revans2
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10301
Old Approach
New Approach
This fixes the performance regression and we are now slightly faster than CPU for the benchmark I have been using (instead of 4x slower)