Update cmake to build udf native [skip ci] #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install cmake '3.20.5' andd add the var 'CUDF_ENABLE_ARROW_S3=OFF' to build cuDF 21.08 native source Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
force-pushed
the
udf-native-cmake-update
branch
from
9608254
to
7930570
Compare
NvTimLiu
commented
Jun 28, 2021
| @@ -117,6 +118,7 @@ | |||
| <arg value="-DCMAKE_CXX_FLAGS=${CMAKE_CXX_FLAGS}"/> | |||
| <arg value="-DGPU_ARCHS=${GPU_ARCHS}"/> | |||
| <arg value="-DPER_THREAD_DEFAULT_STREAM=${PER_THREAD_DEFAULT_STREAM}"/> | |||
| <arg value="-DCUDF_ENABLE_ARROW_S3=${CUDF_ENABLE_ARROW_S3}"/> | |||
There was a problem hiding this comment.
Refer to : cmake build flag CUDF_ENABLE_ARROW_S3 to conditionally build Arrow with S3 filesystem support.
rapidsai/cudf#8531
|
build |
jlowe
approved these changes
Jun 28, 2021
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Aug 8, 2022
This PR is a breaking change that disables Arrow S3 support by default. Enabling this feature by default has caused build issues for many downstream consumers, all of whom (to my knowledge) manually disable support for this feature. Most commonly, that build error appears as `fatal error: aws/core/Aws.h: No such file or directory`. In my understanding, several downstream consumers of cudf no longer rely on Arrow S3 support from this library and instead get S3 access via fsspec. I am not aware of any users of libcudf who rely on this being enabled by default (or enabled at all). See related issues and discussions: #8617, #11333, #8867, #10644 (comment), NVIDIA/spark-rapids#2827. Build errors caused by this default behavior have also been reported internally. cc: @rjzamora @beckernick @jdye64 @randerzander @robertmaynard @jlowe @quasiben if you have comments following our previous discussion. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Nghia Truong (https://github.com/ttnghia) - GALI PREM SAGAR (https://github.com/galipremsagar) - Vyas Ramasubramani (https://github.com/vyasr) - AJ Schmidt (https://github.com/ajschmidt8) URL: #11470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install cmake '3.20.5' andd add the var 'CUDF_ENABLE_ARROW_S3=OFF' to build cuDF 21.08 native source
Signed-off-by: Tim Liu timl@nvidia.com