Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mixed types as string in GpuJsonScan #9993

Merged
merged 8 commits into from
Jan 24, 2024
Merged

Enable mixed types as string in GpuJsonScan #9993

merged 8 commits into from
Jan 24, 2024

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Dec 7, 2023 •
edited

Closes #9353

Depends on rapidsai/cudf#14572

Changes in this PR:

@andygrove
Enable mixed types as string when reading JSON
1fb5b61 
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove self-assigned this Dec 7, 2023
@sameerz sameerz added the feature request New feature or request label Dec 10, 2023
@andygrove andygrove changed the title WIP: Enable mixed types as string when reading JSON Enable mixed types as string when reading JSON Jan 23, 2024
@andygrove andygrove marked this pull request as ready for review January 23, 2024 03:32
@andygrove
Copy link
Contributor Author

build

revans2
revans2 previously approved these changes Jan 23, 2024
View reviewed changes
@andygrove
Copy link
Contributor Author

There are some json_test failures. I am investigating.

test_from_json_struct_of_struct[:

java.lang.IllegalArgumentException: StructType(StructField(name,StringType,true), StructField(age,IntegerType,true)) is not supported for GPU processing yet.
2024-01-23T16:25:04.5839817Z [2024-01-23T16:22:35.824Z]         at com.nvidia.spark.rapids.GpuColumnVector.getNonNestedRapidsType(GpuColumnVector.java:423)
2024-01-23T16:25:04.5840302Z [2024-01-23T16:22:35.824Z]         at com.nvidia.spark.rapids.GpuCast$.doCast(GpuCast.scala:635)
2024-01-23T16:25:04.5841006Z [2024-01-23T16:22:35.824Z]         at org.apache.spark.sql.rapids.GpuJsonToStructs.$anonfun$doColumnar$7(GpuJsonToStructs.scala:221)

test_from_json_struct_of_list:

java.lang.IllegalArgumentException: ArrayType(StructType(StructField(name,StringType,true), StructField(class,StringType,true)),true) is not supported for GPU processing yet.

@andygrove andygrove changed the title Enable mixed types as string when reading JSON Enable mixed types as string in GpuJsonScan Jan 23, 2024
@andygrove andygrove mentioned this pull request Jan 23, 2024
Closed
@andygrove
Copy link
Contributor Author

build

@andygrove andygrove merged commit 53c0f33 into NVIDIA:branch-24.02 Jan 24, 2024
40 checks passed
@andygrove andygrove deleted the mixed-types-json branch January 24, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@andygrove andygrove

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [JSON] A mix of lists and structs within the same column is not supported
3 participants
@andygrove @revans2 @sameerz