Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Check for name collisions with system header macros. #1270

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Check for name collisions with system header macros. #1270

merged 1 commit into from
Sep 9, 2020

Conversation

alliepiper
Copy link
Collaborator

Fix places where using I for an identifier was causing conflicts
with complex.h.

Fixes #1244.

@alliepiper alliepiper added this to the 1.10.0 milestone Sep 3, 2020
@alliepiper
Copy link
Collaborator Author

Running CI (with thrust/cub#55) in CL 29026926.

@alliepiper alliepiper added testing: gpuCI passed Passed gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Sep 3, 2020
@alliepiper
Check for name collisions with system header macros.
a13c252 
Fix places where using `I` for an identifier was causing conflicts
with complex.h.

Fixes NVIDIA#1244.
@alliepiper alliepiper merged commit 691b021 into NVIDIA:main Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brycelelbach brycelelbach brycelelbach approved these changes

Assignees
No one assigned
Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Compilation fails when including complex.h
2 participants
@alliepiper @brycelelbach