Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile and launch script #23

Closed
wants to merge 4 commits into from
Closed

Add Dockerfile and launch script #23

wants to merge 4 commits into from

Conversation

dustinfreeman
Copy link

@dustinfreeman dustinfreeman commented Aug 28, 2018

I hope this docker image is useful to others! Would have saved me a couple days of trial and error work fighting competing dependencies

I've tested this Dockerfile so far as it can run bash ./scripts/test_1024_g1.sh. I have a single GPU setup so I can't test any multi-GPU features.

If I encounter further issues as I use vid2vid, I'll update this pull request.

@dustinfreeman
Copy link
Author

Update: this Dockerfile does not install CUDA drivers correctly on a Google Compute server. Working on it and will update when I have a solution

@dustinfreeman
Copy link
Author

I have updated the pull request after extensive testing on a fresh Ubuntu 16.04 LTS instance offered by Google Cloud Compute.

docker/pre_docker_install.sh is meant to be run before the docker image is built, to install prerequisites on the base OS. It seems nvidia drivers need to be installed outside the docker image.

@tcwang0509
Copy link
Contributor

Thanks for your kindness to provide the scripts! We're actually not allowed to take pull requests outside the company. But I've integrated your dockerfiles into the main branch. Cheers!

@dustinfreeman
Copy link
Author

dustinfreeman commented Sep 20, 2018

Understood, though that is unfortunate - I'm still iterating on this (e.g. I think the model downloading is not robust), and will update this pull request as I debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants