-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for legal results filename #366
Conversation
It may be worth noting that G3D also has an option for Update: |
Currently this branch also introduces an issue with descriptions/user names that include spaces. This should be resolved before merging... |
For now I've moved to using This may only cause issues when something like 2 user IDs/experiment descriptions only differ by sequential illegal characters in which case they may collide... I think this branch is a fine fix for the issue for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passed and this looks like a solid, straightforward improvement.
Actually, it looks like there's a likely bug with an extra |
This should be fixed with 137b0da |
This branch adds a
FilePath::isLegalFilename()
check on the filename used for the results database. Previously the results could fail to write due to an illegal character in either an experiment description or a user name.The new check should throw an exception when any invalid filename character is detected in the results filename. It is worth noting this may catch characters that technically legal but not encouraged for file naming.
Merging this PR closes #351