-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
696 click ordering #783
696 click ordering #783
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #783 +/- ##
==========================================
+ Coverage 59.07% 59.68% +0.6%
==========================================
Files 71 71
Lines 694 692 -2
==========================================
+ Hits 410 413 +3
+ Misses 284 279 -5
Continue to review full report at Codecov.
|
Looks good, and I approved the percy diffs. But this is waiting on the merge & tag of that last update to ember-mapbox-composer, right? And then another change here to bump the addone version one more time ? |
Not sure I understand. I think these changes include a version bump to grab the necessary version of mapbox composer. |
Closes #696 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks GREAT !
Codecov Report
@@ Coverage Diff @@
## develop #783 +/- ##
==========================================
+ Coverage 59.07% 59.68% +0.6%
==========================================
Files 71 71
Lines 694 692 -2
==========================================
+ Hits 410 413 +3
+ Misses 284 279 -5
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## develop #783 +/- ##
==========================================
+ Coverage 59.07% 59.68% +0.6%
==========================================
Files 71 71
Lines 694 692 -2
==========================================
+ Hits 410 413 +3
+ Misses 284 279 -5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #783 +/- ##
==========================================
+ Coverage 59.07% 59.68% +0.6%
==========================================
Files 71 71
Lines 694 692 -2
==========================================
+ Hits 410 413 +3
+ Misses 284 279 -5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #783 +/- ##
==========================================
+ Coverage 60.11% 60.7% +0.59%
==========================================
Files 72 72
Lines 707 705 -2
==========================================
+ Hits 425 428 +3
+ Misses 282 277 -5
Continue to review full report at Codecov.
|
Hmm something a little weird is happening where lots now have multiple lot number labels Diff example: https://percy.io/NYC-Planning-Labs/zola/builds/1419006/view/93862159/1280?browser=firefox&mode=diff |
You can if you turn off tax lots and they seem to work fine. In the original issue, @andycochran mentioned that "tax lots should ALWAYS be the topmost layer" - so I'm confused by this. |
Yeah - I wouldn't read too much into the diffing here. The maps generate PNG images (which are there screenshottable by Percy), so there'll almost always be weird little artifacts here and there. It's mostly there to catch big things - so if you see a lot of red, that's usual a sign that something's up. In this case, it's probably fine - you should just verify that it's working in the branch preview. |
7e50f28
to
0690a5d
Compare
Reorder default layergroup state to put circle features, then tax lots on top Bump mapbox-composer fix to address 696 Enable test for coverage
0690a5d
to
afb6b72
Compare
Unfortunately, this is not just a Percy artifact... I'm seeing it in staging right now. That being said I think we should merge this branch to resolve all these issues, and we can address the multiple lot IDs separately. |
@allthesignals Andy's comment did say tax lots on top, but after we had discussed this more, we agreed points should be on top followed by tax lots. I had updated the title and description of the issue accordingly, but I think this raises an important point that we need a better way of clearly indicating the final decision on an issue vs. preserving discussion leading up to it. I feel like the description is the best place for that, so you don't have to go digging through comments, but we should discuss and agree on the preferred method. |
Fixes a regression with tooltip templating and addresses #696 by upgrading
ember-mapbox-composer
which includes a better approach to handling hover events for overlapping layers. Needs some review to see if the behavior has improved.@hannahkates if you can find specific issues maybe GIF them or show me ways to manually test this.
Closes #696 Closes #785 Closes #786 Closes #785
Thanks!