Update Book Registry Sync to include necessary callbacks for the

Background Fetch delegate.

Simplified/NYPLAppDelegate.m

@@ -78,14 +78,11 @@ - (BOOL)application:(__attribute__((unused)) UIApplication *)application
 }
 
 - (void)application:(__attribute__((unused)) UIApplication *)application
-performFetchWithCompletionHandler:(void (^)(UIBackgroundFetchResult))completionHandler
+performFetchWithCompletionHandler:(void (^)(UIBackgroundFetchResult))backgroundFetchHandler
 {
   // Only the current Library Account will perform background fetches.
-  [[NYPLBookRegistry sharedRegistry] syncWithCompletionHandler:^(BOOL __unused success) {
-    //GODO this block is not being called in a lot of places. come back to this.
-    //GODO is a sync being called anywhere else when the app launches?
-    completionHandler(UIBackgroundFetchResultNewData);
-  }];
+  [[NYPLBookRegistry sharedRegistry] syncWithCompletionHandler:nil
+                                        backgroundFetchHandler:backgroundFetchHandler];
 }
 
 - (BOOL)application:(__attribute__((unused)) UIApplication *)application handleOpenURL:(NSURL *)url

Simplified/NYPLBookRegistry.h

@@ -49,6 +49,10 @@ static NSString *const NYPLBookProcessingDidChangeNotification =
 // not to be called.
 - (void)syncWithCompletionHandler:(void (^)(BOOL success))handler;
 
+// Calls `syncWithCompletionHandler` including required callbacks for the Background Fetch delegate.
+- (void)syncWithCompletionHandler:(void (^)(BOOL success))handler
+            backgroundFetchHandler:(void (^)(UIBackgroundFetchResult))fetchResult;
+
 // Calls syncWithCompletionHandler: with a handler that presents standard success/failure alerts on
 // completion.
 - (void)syncWithStandardAlertsOnCompletion;

Simplified/NYPLBookRegistry.m

@@ -262,13 +262,21 @@ - (void)justLoad
 }
 
 - (void)syncWithCompletionHandler:(void (^)(BOOL success))handler
+{
+  [self syncWithCompletionHandler:handler backgroundFetchHandler:nil];
+}
+
+- (void)syncWithCompletionHandler:(void (^)(BOOL success))handler
+            backgroundFetchHandler:(void (^)(UIBackgroundFetchResult))fetchResult
 {
   @synchronized(self) {
     if(self.syncing) {
+      fetchResult(UIBackgroundFetchResultNoData);
       return;
     } else if (![[NYPLAccount sharedAccount] hasBarcodeAndPIN]) {
       [[NSOperationQueue mainQueue] addOperationWithBlock:^{
         if(handler) handler(NO);
+        fetchResult(UIBackgroundFetchResultNoData);
       }];
       return;
     } else {
@@ -288,6 +296,7 @@ - (void)syncWithCompletionHandler:(void (^)(BOOL success))handler
        [[NSOperationQueue mainQueue]
         addOperationWithBlock:^{
           if(handler) handler(NO);
+          fetchResult(UIBackgroundFetchResultFailed);
         }];
        return;
      }
@@ -296,6 +305,7 @@ - (void)syncWithCompletionHandler:(void (^)(BOOL success))handler
        // A reset must have occurred.
        self.syncing = NO;
        [self broadcastChange];
+       fetchResult(UIBackgroundFetchResultNoData);
        return;
      }
 
@@ -338,6 +348,7 @@ - (void)syncWithCompletionHandler:(void (^)(BOOL success))handler
        [[NSOperationQueue mainQueue]
         addOperationWithBlock:^{
           if(handler) handler(YES);
+          fetchResult(UIBackgroundFetchResultNewData);
         }];
      };
 

Simplified/NYPLUserNotifications.swift

@@ -21,17 +21,6 @@ let DefaultActionIdentifier = "UNNotificationDefaultActionIdentifier"
     }
   }
 
-  /* Just a proposal for now...
-   if #available(iOS 12.0, *) {
-   //GODO TODO i'm not convinced "provisional" is the UX we want. come back to this
-   unCenter.requestAuthorization(options: [.provisional,.badge,.sound,.alert]) { (granted, error) in
-   if granted {
-   Log.info(#file, "Full Notification Authorization granted.")
-   }
-   }
-   }
- **/
-
   /// Create a local notification if a book has moved from the "holds queue" to
   /// the "reserved queue", and is available for the patron to checkout.
   class func compareAvailability(cachedRecord:NYPLBookRegistryRecord, andNewBook newBook:NYPLBook)