Fix scoping bug in download_datafiles #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable `outstring` defined in a `with` statement is used outside the scope of the `with` in `get_question_data` and `get_event_data`, resulting in question and event data both throwing "Error reading record" errors (the exception being "I/O operation on closed file") when running `download_datafiles` from the psiturk shell.
|
Thanks for this! |
|
Yes, indeed, thank you. It looks like I introduced this bug last October.
I'm surprised that my IDE's code inspection didn't flag, or I must have missed it.
Jacob
…On Mon, Mar 29, 2021, 6:12 PM Dave Eargle ***@***.***> wrote:
Thanks for this!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#487 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM5SQJ7UUJYK6H4JGPHKCDTGD3NJANCNFSM42ARIAIQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
outstringdefined in awithstatement is used outside the scope of thewithinget_question_dataandget_event_data, resulting in question and event data both throwing "Error reading record" errors (the exception being "I/O operation on closed file") when runningdownload_datafilesfrom the psiturk shell.