Skip to content
This repository has been archived by the owner on Mar 23, 2018. It is now read-only.

bring master branch up to speed with development #265

Merged
merged 87 commits into from
Nov 22, 2016
Merged

bring master branch up to speed with development #265

merged 87 commits into from
Nov 22, 2016

Conversation

jgpawletko
Copy link
Member

No description provided.

@da70 @chrpr
catalog_controller_spec: new convenience method blacklight_configurat…
c63e262 
…ion()
@da70 @chrpr
catalog_controller_spec: new methods for returning expected ordering …
0f4ad74 
…of fields for facet, index, and show fields
@da70 @chrpr
catalog_controller_spec: tests for correct ordering of facet, index, …
bf4cfbd 
…and show fields in Blacklight configuration
@da70 @chrpr
catalog_controller_spec: put Blacklight config tests in nested descri…
92a14d9 
…be context
@da70 @chrpr
catalog_controller_rspc: test "available" index field :label, :text, …
c278d84 
…and :helper_method
@da70 @chrpr
catalog_controller_spec: test "available" show field :label, :text, a…
f499098 
…nd :helper_method
@da70 @chrpr
catalog_controller_spec: use "addinfolink" field for show field tests…
93abbf6 
… instead of "available"
@da70 @chrpr
catalog_controller_spec: test "type" facet field :label"
218f99d
@da70 @chrpr
catalog_controller.rb: start on replacement of conf.add_facet_field s…
7c17792 
…tuff
@da70 @chrpr
MetadataFields renames: change *fields* to *field_names*
2c56d54
@da70 @chrpr
metadata_fields_spec.rb: rename *fields* -> *field_names*
de4fe13
@da70 @chrpr
metadata_fields.rb: update comments "fields" -> "field names"
6734b23
@da70 @chrpr
add_field_names_by_ns: straighten out "field" vs "field_name" references
8a9a659
@da70 @chrpr
add_field_names: straighten out "field" vs "field_name" references
82f593b
@da70 @chrpr
add_field_names_by_ns BUGFIX: rename field -> field_name
15375b5
@da70 @chrpr
metadata_fields.rb: new methods add_all_fields() and add_fields_by_ns()
f12524e
@da70 @chrpr
metadata_fields.rb: new methods get_facetable_fields_in_display_order…
f57d798 
… and sort_fields_by_display_attribute
@da70 @chrpr
metadata_fields.yml: add "display" sections to all terms
898cec6
@da70 @chrpr
catalog_controller.rb: replace hardcoded add_facet_field calls with n…
31555a2 
…ew MetadataFields loop code
@da70 @chrpr
MetadataFields: return fields array of hashes instead of 2-element ar…
aff84be 
…rays
@da70 @chrpr
metadata: re-create type/format confusion from before so things work …
d0ef3b9 
…right for the time being
@da70 @chrpr
catalog_controller_spec.rb: remove index fields from expected that we…
ab13c75 
… are not using [+]

"As an Ichabod developer, I want to be able to update nyucore yaml file without having to update catalog controller, so that my code is DRYer."
https://www.pivotaltracker.com/n/projects/1025368/stories/113569497
@da70 @chrpr
catalog_controller_spec.rb: remove catalog controller index fields th…
0644492 
…at we are not using [+]

"As an Ichabod developer, I want to be able to update nyucore yaml file without having to update catalog controller, so that my code is DRYer."
https://www.pivotaltracker.com/n/projects/1025368/stories/113569497
@da70 @chrpr
metadata_fields.yml: indent the display.facet section
7e8e3b7
@da70 @chrpr
metadata_fields.yml: add search_result section to display sections in…
2276af8 
… "true" fields
@da70 @chrpr
catalog_controller.rb: change facetable_fields to facet_fields
93cb285
@da70 @chrpr
metadata_fields.rb: standardize on "facet" instead of "facetable"
5ccc333
@da70 @chrpr
metadata_fields.yml: add the search_result "false" sections
4fea304
@da70 @chrpr
catalog_controller.rb: removed obsolete TODO
c136af7
@da70 @chrpr
metadata_fields.yml BUGFIX: publisher had 2 search_result sections an…
fd2094b 
…d geometry had none
chrpr and others added 26 commits October 18, 2016 11:07
@chrpr
metadata_fields_spec fixes: remove hardcoded 'all', extract get_field…
4008d74 
…_by_name_from_fields_array, test values of addinfolink attributes
@chrpr
NYU Press isbn 9780814712917 no longer in first 5 documents loaded
95adb70
@chrpr
Moving metadata_fields to lib
6e8ee43
@chrpr
Adding comments about splat in catalog_controller.rb
4677fc0
@chrpr
Fixing duplicate METADATA_FIELDS[ns][:fields]
00c2878
@chrpr
Flattening (sort of) display variables for use in controller
462b4e5
@chrpr
Genre is the new 12 under detail; now rights is 19 (was 18)
c264a52
@chrpr
update specs to match collection & genre feature
8d0a6f8
@chrpr
changing whitespace in qf to match development
e113b44
@chrpr
adding queryable to metadata_fields, plus method and spec to process
195ac3c
@chrpr
Running qf in catalog controller off metadata fields
208dfaa
@chrpr
Adding spec for index title field
b1f5a37
@chrpr
Processing display config
c56f3e5
@chrpr
Add config section to yaml, fix metadata_fields
b452792
@ekate
Change permissions for collections
a2f26ef
@chrpr
catalog_controller uses get_config_value_by_key('index_title_field')
b4230d6
@chrpr
rspec to test 'get_config_value_by_key'
6ff8925
@ekate
Deleted unused step
073a2fa
@jgpawletko
Merge pull request #263 from NYULibraries/chore/collection_authorization
93ba057 
Change permissions for collections
@chrpr
Rerecorded cassettes & makin cukes green. Thanks Esha!
d66b992
@chrpr
Updating fixture fields to reflect new attributes
addf010
@chrpr
tabs to spaces on metadata fields
17b1966
@chrpr
CONFIG_DATA, emsg pattern, and get_config_value_by_key fix
d6d7668
@chrpr
finish emsg edits
1022c54
@chrpr
Removing stray paren
bdc5291
@jgpawletko
Merge pull request #264 from NYULibraries/chore/113569497_full-displa…
d3c64fa 
…y-runs-off-yaml

Chore/113569497 full display runs off yaml
@coveralls
Copy link

coveralls commented Nov 22, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 99.289% when pulling d3c64fa on development into c2dbd39 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 99.289% when pulling d3c64fa on development into c2dbd39 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 99.289% when pulling d3c64fa on development into c2dbd39 on master.

@jgpawletko jgpawletko merged commit 14e0ef8 into master Nov 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgpawletko @coveralls @da70 @chrpr @rdrzewicki @ekate