This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Code clean-up #28
Merged
Code clean-up #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the chip magic detection to make sure the register read is converted to it's signed 2's complements form, which is what esptool.py uses for representing the chipmagic and why 0xfff0c101 was not matching before. 0xfff0c101 is the signed 2's compliment hex value for -999167 This would also fix the S3 chipmagic detection.
Stubs for ESP32-S2, ESP32 and ESP8266 updated to the ones found in esptool 3.1
reader.cancel() causes the Promise returned by the read() operation running on the readLoop to return immediately with { value: undefined, done: true } and thus breaking the loop and exiting readLoop();
This means there is no need to have the stopReadLoop to flag the loop and cause it to exit because it was already exiting as soon as the reader.cancel() was called from the setBaudrate method.
balloob
approved these changes
Jun 26, 2021
balloob
pushed a commit
that referenced
this pull request
Mar 25, 2022
Fix Mac Address for S2 and S3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the chip magic detection to make sure the register read is converted to its signed 2's complements form, which is what esptool.py uses for representing the chipmagic and why 0xfff0c101 was not matching before.
0xfff0c101 is the signed 2's compliment hex value for -999167
Stubs for ESP32-S2, ESP32 and ESP8266 updated to the ones found in esptool 3.1
reader.cancel() causes the Promise returned by the read() operation running on the readLoop to return immediately with { value: undefined, done: true } and thus breaking the loop and exiting readLoop();
This means there is no need to have the stopReadLoop to flag the loop and cause it to exit because it was already exiting as soon as the reader.cancel() was called from the setBaudrate method.