Skip to content
This repository has been archived by the owner on Jul 20, 2022. It is now read-only.

Code clean-up #28

Merged
merged 5 commits into from
Jun 26, 2021
Merged

Code clean-up #28

merged 5 commits into from
Jun 26, 2021

Commits on Jun 26, 2021

  1. signed 2's complements for chipmagic 

    Updating the chip magic detection to make sure the register read is converted to it's signed 2's complements form, which is what esptool.py uses for representing the chipmagic and why 0xfff0c101 was not matching before.

0xfff0c101 is the signed 2's compliment hex value for -999167

This would also fix the S3 chipmagic detection.
    @conradopoole
    conradopoole committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    7fcdb70 View commit details
    Browse the repository at this point in the history

  2. stubs update 3.1 

    Stubs for ESP32-S2, ESP32 and ESP8266 updated to the ones found in esptool 3.1
    @conradopoole
    conradopoole committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    a2bdfcd View commit details
    Browse the repository at this point in the history

  3. readLoop changes. 

    reader.cancel() causes the Promise returned by the read() operation running on the readLoop to return immediately with { value: undefined, done: true } and thus breaking the loop and exiting readLoop();

This means there is no need to have the stopReadLoop to flag the loop and cause it to exit because it was already exiting as soon as the reader.cancel() was called from the setBaudrate method.
    @conradopoole
    conradopoole committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    012959b View commit details
    Browse the repository at this point in the history

  4. prettier

    @conradopoole
    conradopoole committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    7240026 View commit details
    Browse the repository at this point in the history

  5. adding common baudrates to constants

    @conradopoole
    conradopoole committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    51a151d View commit details
    Browse the repository at this point in the history