Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set a comment to expire #685

Open
tgriep opened this issue Aug 20, 2019 · 5 comments
Open

Add ability to set a comment to expire #685

tgriep opened this issue Aug 20, 2019 · 5 comments

Comments

@tgriep
Copy link

tgriep commented Aug 20, 2019

When in the Nagios web interface and viewing a comment, there is a field called Expires which is to display when a comment is set to expire.
Currently there is not a way to set a comment to expire so can that get added in to a future release of Nagios Core?

@sawolf
Copy link
Member

sawolf commented Aug 20, 2019

Given that the column exists, it's strange to me that there isn't already an issue for this.

Yes, I think it makes a lot of sense to add this.

@ericloyd
Copy link

Please yes. And, we still need a mass de-acknowledge, while we're at it. :-)

@sawolf
Copy link
Member

sawolf commented Aug 21, 2019

@ericloyd that's more of an XI feature, right? I don't mind making a new issue for it, but I want to make sure it goes in the right place

@ericloyd
Copy link

Acknowledge is a core function, not just an XI function, right? If we're talking about expiring comments, I'd love to see expirable acks as well. I know, it's a feature request, but I'm just trying to sneak it in. :-)

@sawolf
Copy link
Member

sawolf commented Aug 21, 2019

OK, that makes sense. I'm not sure what the code looks like around there but I'll see what I can do

iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 6, 2020
This commit sets up saving and expiration time for the ADD_[HOST/SERVICE]_COMMENT commands. It requires a new parameter, so doc will change. Also needs field added to GUI. Must figure out event handler to remove comment once expired.
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 10, 2020
Intermediate commits to get datetime to work.
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 11, 2020
Small clean up for docker and delete macro.
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 11, 2020
Small clean up for docker and delete macro.
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 11, 2020
Small clean up for docker and delete macro.
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 11, 2020
Get the GUI integrated to expire comments.
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 13, 2020
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 13, 2020
Merge pull request NagiosEnterprises#527 from ctrlpvim/fix-520

Fix NagiosEnterprises#520
Give kazukazuinaina proper credit.
Add sponsor button
Merge pull request NagiosEnterprises#879 from LinuxSuRen/patch-1

Use Chinese punctuation
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 13, 2020
Merge pull request NagiosEnterprises#527 from ctrlpvim/fix-520

Fix NagiosEnterprises#520
Give kazukazuinaina proper credit.
Add sponsor button
Merge pull request NagiosEnterprises#879 from LinuxSuRen/patch-1

Use Chinese punctuation
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 13, 2020
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 13, 2020
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 17, 2020
Rollback config.guess and config.sub file changes.
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 17, 2020
Rollback config.guess and config.sub file changes.
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 17, 2020
Remove test files and revert install-sh.
iwhite-nagios added a commit to iwhite-nagios/nagioscore that referenced this issue Feb 17, 2020
sawolf added a commit that referenced this issue Feb 19, 2020
#685 - Add ability to remove expiring comments via Nagios Command Pipe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants