Renaming of generic variables, simpler variable declarations, and removal of legacy 16-bit code #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FluffyQuack
commented
Oct 4, 2022
FluffyQuack
commented
- Renamed various var_# variables to better describe their purpose.
- Moved a lot of variable declarations to where they're first used to improve readability (and might slightly improve optimization during compilation as a lot of variables got reduced scope).
- Removed the "vsync" argument for set_pal() (and related functions) as it wasn't used.
- Removed references to __pascal, near, and far as they're obsolete when compiling for 32-bit or 64-bit.
…mpilation. Also simplified a few variable declarations within functions.
…snippet in clip_char()
… to when the variable is first used.
…n a previous commit.
…e ignored in 32-bit and 64-bit compilers. Replaced all near and far references of malloc, free, memset, and memcpy with the normal calling name of those functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.