Register quick key presses #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…And updated ingame input code to use the new system, which makes it possible to check for button press that are pressed and released between game updates, reducing chances for dropped input (dropped input can still happen if user holds down a key, and then releases and re-presses between game updates).
…moved KEYSTATE_RELEASED_NEW bitflag as there was no use for it afterall.
…E_HELD_NEW to key_states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user is very quick with key presses (that is, the user presses and releases a key within the 83.333ms window between game updates), then the game ignores those key presses. This PR fixes that and makes the controls feel responsive overall. I find it's especially noticeable during combat where you might briefly tap up/shift to parry/attack.